Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk/go] Check for pulumiplugin.json in GetRequiredPlugins #8516

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 1, 2021

Description

Checks for pulumiplugin.json in Dir (from go list -m -json -mod=mod all).

Fixes #7245

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe self-assigned this Dec 1, 2021
@iwahbe iwahbe requested review from justinvp and a team December 1, 2021 18:33
@pgavlin
Copy link
Member

pgavlin commented Dec 1, 2021

Have we validated that the module sources always include all of the files present in the module's repo? I'm wondering if we need to update our Go codegen to ensure that the pulumiplugin.json file is referenced from the code via a //go:embed directive or similar.

@iwahbe
Copy link
Member Author

iwahbe commented Dec 1, 2021

Have we validated that the module sources always include all of the files present in the module's repo? I'm wondering if we need to update our Go codegen to ensure that the pulumiplugin.json file is referenced from the code via a //go:embed directive or similar.

Our codegen does not currently include pulumiplugin.json at all for go. That will be added in another PR. Performing a quick test, it seems like files are just included. It doesn't seem like we need to include a //go:embed directive.

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've also verified that pulumiplugin.json file is included in the module.

@iwahbe iwahbe merged commit feef62e into master Dec 2, 2021
@pulumi-bot pulumi-bot deleted the iwahbe/7245/go-check-for-pulumiplugin-json branch December 2, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go: Support custom server URLs for plugins
3 participants