[codegen/python] emit pulumiplugin.json by default
#8527
Conversation
|
Diff for pulumi-azuread with merge commit 8c49262 |
|
Diff for pulumi-random with merge commit 90c0665 |
|
Diff for pulumi-random with merge commit 8c49262 |
|
Diff for pulumi-azuread with merge commit 90c0665 |
|
Diff for pulumi-kubernetes with merge commit 8c49262 |
|
Diff for pulumi-kubernetes with merge commit 90c0665 |
|
Diff for pulumi-gcp with merge commit 8c49262 |
|
Diff for pulumi-gcp with merge commit 90c0665 |
|
Diff for pulumi-azure with merge commit 90c0665 |
|
Diff for pulumi-azure with merge commit 8c49262 |
|
Diff for pulumi-aws with merge commit 8c49262 |
pkg/codegen/internal/test/testdata/cyclic-types/python/pulumi_example/pulumiplugin.json
Outdated
Show resolved
Hide resolved
| @@ -1941,15 +1941,14 @@ func genPulumiPluginFile(pkg *schema.Package) ([]byte, error) { | |||
| plugin := &plugin.PulumiPluginJSON{ | |||
| Resource: true, | |||
| Name: pkg.Name, | |||
| Version: "${PLUGIN_VERSION}", | |||
There was a problem hiding this comment.
Nice. I like this. Now, when this codegen change is adopted by the providers we aren't forced to make a change to the Makefile to search/replace this value. We can do it at our leisure. And we can use jq to add the version property.
I do think we'll end up wanting to update our provider Makefiles to do this, because it'll fix being able to automatically download plugins for dev builds of the package, but that's not a huge priority.
|
Diff for pulumi-aws with merge commit 90c0665 |
Codecov Report
@@ Coverage Diff @@
## master #8527 +/- ##
==========================================
+ Coverage 58.59% 58.61% +0.02%
==========================================
Files 634 634
Lines 96844 96843 -1
Branches 1378 1378
==========================================
+ Hits 56744 56769 +25
+ Misses 36831 36804 -27
- Partials 3269 3270 +1
Continue to review full report at Codecov.
|
|
Diff for pulumi-azure-native with merge commit 8c49262 |
|
Diff for pulumi-azure-native with merge commit 90c0665 |
|
Diff for pulumi-random with merge commit 417a7e6 |
|
Diff for pulumi-azuread with merge commit 417a7e6 |
|
Diff for pulumi-kubernetes with merge commit 417a7e6 |
|
Diff for pulumi-gcp with merge commit 417a7e6 |
|
Diff for pulumi-aws with merge commit 417a7e6 |
|
Diff for pulumi-azure with merge commit 417a7e6 |
|
Diff for pulumi-azure-native with merge commit 417a7e6 |
pulumi-bot
deleted the
iwahbe/8526/python-emit-pulumiplugin-by-default
branch
Description
Remove the flag that makes
pulumiplugin.jsonoptional. We will now emit unconditionally.Fixes #8526
Checklist