Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt language hosts out of PULUMI_IGNORE_AMBIENT_PLUGINS #8576

Merged
merged 3 commits into from Dec 10, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 9, 2021

Description

Opt language hosts out of PULUMI_IGNORE_AMBIENT_PLUGINS. Currently, setting PULUMI_IGNORE_AMBIENT_PLUGINS breaks the Automation API because the Automation API does not have a language specific package manager to fall back to.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe requested a review from a team December 9, 2021 20:32
@iwahbe iwahbe self-assigned this Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #8576 (0d49bcd) into master (457ee06) will decrease coverage by 18.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #8576       +/-   ##
===========================================
- Coverage   58.69%   40.22%   -18.48%     
===========================================
  Files         634      627        -7     
  Lines       96946    94705     -2241     
  Branches     1378     1378               
===========================================
- Hits        56902    38094    -18808     
- Misses      36780    53972    +17192     
+ Partials     3264     2639      -625     
Impacted Files Coverage Δ
sdk/go/common/workspace/plugins.go 50.43% <100.00%> (-5.78%) ⬇️
pkg/codegen/docs.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/codegen/go/gen_spill.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/codegen/dotnet/templates.go 0.00% <0.00%> (-100.00%) ⬇️
sdk/go/common/resource/stack.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/codegen/internal/utils/host.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/codegen/hcl2/model/format/func.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/codegen/python/python.go 0.00% <0.00%> (-97.80%) ⬇️
pkg/codegen/utilities_types.go 3.54% <0.00%> (-96.46%) ⬇️
pkg/codegen/go/gen_program_optionals.go 0.00% <0.00%> (-94.21%) ⬇️
... and 164 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457ee06...0d49bcd. Read the comment docs.

@emiliza emiliza added capacity/community-customer kind/enhancement Improvements or new features size/S Estimated effort to complete (1-2 days). labels Dec 9, 2021
@emiliza emiliza added this to the 0.66 milestone Dec 9, 2021
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says, LGTM.

@iwahbe iwahbe merged commit 278055c into master Dec 10, 2021
@pulumi-bot pulumi-bot deleted the iwahbe/ignore-ambient-plugins-exclude-language-plugins branch December 10, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants