Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give user defined variables precedence in GetCommandResults #8610

Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Dec 18, 2021

Description

Fixes #8356

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe requested a review from a team December 18, 2021 00:08
@iwahbe iwahbe self-assigned this Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #8610 (e731b99) into master (888cbec) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8610      +/-   ##
==========================================
- Coverage   58.94%   58.66%   -0.29%     
==========================================
  Files         634      555      -79     
  Lines       97356    93979    -3377     
  Branches     1382     1382              
==========================================
- Hits        57389    55133    -2256     
+ Misses      36718    35593    -1125     
- Partials     3249     3253       +4     
Impacted Files Coverage Δ
sdk/go/common/testing/environment.go 76.72% <100.00%> (+7.15%) ⬆️
...dk/go/common/resource/plugin/langruntime_plugin.go 67.29% <0.00%> (-1.89%) ⬇️
sdk/go/common/resource/properties.go 82.87% <0.00%> (-0.83%) ⬇️
sdk/dotnet/Pulumi/Core/InputList.cs
sdk/dotnet/Pulumi/Deployment/InvokeOptions.cs
sdk/dotnet/Pulumi/Core/InputJson.cs
sdk/dotnet/Pulumi/Resources/InputArgs.cs
sdk/dotnet/Pulumi/Core/Alias.cs
sdk/dotnet/Pulumi/Core/Options.cs
sdk/dotnet/Pulumi/Config.cs
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888cbec...e731b99. Read the comment docs.

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat and tidy, but as always, would be better with a tiny unit test, just to get in the habit of recording what we want the software to do.

Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@iwahbe iwahbe merged commit aa2368d into master Jan 5, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/8356/GetCommandResults.Env-allow-user-override branch January 5, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-order env vars in testing
2 participants