-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give user defined variables precedence in GetCommandResults #8610
Give user defined variables precedence in GetCommandResults #8610
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8610 +/- ##
==========================================
- Coverage 58.94% 58.66% -0.29%
==========================================
Files 634 555 -79
Lines 97356 93979 -3377
Branches 1382 1382
==========================================
- Hits 57389 55133 -2256
+ Misses 36718 35593 -1125
- Partials 3249 3253 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat and tidy, but as always, would be better with a tiny unit test, just to get in the habit of recording what we want the software to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Description
Fixes #8356
Checklist