Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk/nodejs] Add pluginServerURL #8698

Merged
merged 7 commits into from
Jan 10, 2022
Merged

[sdk/nodejs] Add pluginServerURL #8698

merged 7 commits into from
Jan 10, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 6, 2022 •
edited
Loading

Tests that this work are included in the PR.

Description

Fixes #8687

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe
Add pluginServerURL to the nodejs SDK
5725971 
Tests that this work are included in the PR.
@iwahbe iwahbe self-assigned this Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022 •
edited
Loading

Codecov Report

Merging #8698 (524c325) into master (e728425) will decrease coverage by 0.25%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8698      +/-   ##
==========================================
- Coverage   59.02%   58.77%   -0.26%     
==========================================
  Files         634      555      -79     
  Lines       97389    94074    -3315     
  Branches     1382     1385       +3     
==========================================
- Hits        57485    55289    -2196     
+ Misses      36639    35520    -1119     
  Partials     3265     3265
Impacted Files Coverage Δ
sdk/nodejs/runtime/invoke.ts 22.99% <0.00%> (-0.38%) ⬇️
sdk/nodejs/runtime/resource.ts 54.44% <50.00%> (-0.03%) ⬇️
pkg/codegen/nodejs/gen.go 83.70% <100.00%> (+0.50%) ⬆️
sdk/nodejs/resource.ts 30.31% <100.00%> (+0.27%) ⬆️
...dk/go/common/resource/plugin/langruntime_plugin.go 67.29% <0.00%> (-1.89%) ⬇️
sdk/dotnet/Pulumi/Resources/CallArgs.cs
sdk/dotnet/Pulumi/Deployment/DeploymentInstance.cs
...umi/Serialization/ImmutableDictionaryExtensions.cs
sdk/dotnet/Pulumi/Core/Input.cs
sdk/dotnet/Pulumi/Resources/CustomResource.cs
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5a8a1...524c325. Read the comment docs.

@iwahbe iwahbe requested review from justinvp and a team January 6, 2022 23:05
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Diff for pulumi-random with merge commit 90ff702

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Diff for pulumi-azuread with merge commit 90ff702

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Diff for pulumi-kubernetes with merge commit 90ff702

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Diff for pulumi-gcp with merge commit 90ff702

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Diff for pulumi-azure with merge commit 90ff702

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Diff for pulumi-aws with merge commit 90ff702

@iwahbe iwahbe changed the title Add pluginServerURL to the nodejs SDK [sdk/nodejs] Add pluginServerURL Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Diff for pulumi-azure-native with merge commit 90ff702

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-random with merge commit ea48bac

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-azuread with merge commit ea48bac

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-kubernetes with merge commit ea48bac

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-gcp with merge commit ea48bac

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-azure with merge commit ea48bac

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-aws with merge commit ea48bac

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-azure-native with merge commit ea48bac

justinvp
justinvp reviewed Jan 7, 2022
View reviewed changes
pkg/codegen/nodejs/gen.go Outdated Show resolved Hide resolved
sdk/nodejs/resource.ts Outdated Show resolved Hide resolved
sdk/nodejs/resource.ts Show resolved Hide resolved
pkg/codegen/nodejs/gen.go Show resolved Hide resolved
sdk/nodejs/runtime/resource.ts Show resolved Hide resolved
@justinvp justinvp mentioned this pull request Jan 7, 2022
Merged
3 tasks
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-random with merge commit 9859c88

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-kubernetes with merge commit 9859c88

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-azuread with merge commit 9859c88

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-gcp with merge commit 9859c88

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-random with merge commit cdb2e32

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-azure with merge commit 9859c88

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-azuread with merge commit cdb2e32

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-kubernetes with merge commit cdb2e32

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-gcp with merge commit cdb2e32

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Diff for pulumi-aws with merge commit 9859c88

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

Diff for pulumi-azure with merge commit cdb2e32

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

Diff for pulumi-aws with merge commit cdb2e32

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

Diff for pulumi-azure-native with merge commit 9859c88

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

Diff for pulumi-azure-native with merge commit cdb2e32

@iwahbe iwahbe requested a review from justinvp January 8, 2022 00:39
justinvp
justinvp approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwahbe iwahbe merged commit 9a5ba09 into master Jan 10, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/8687/nodejs-sdk-pluginServerURL-hookup branch January 10, 2022 23:54
@EronWright EronWright mentioned this pull request Dec 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sdk/nodejs] Support for custom server urls
2 participants
@iwahbe @justinvp