[codegen/dotnet] Allow generated SDKs to have a global namespace other then `Pulumi` #8735

iwahbe · 2022-01-12T18:57:59Z

Description

If a schema author wants to replace the Pulumi global namespace, they can add "rootNamespace": "NewNamespace" to the .language.csharp section.

Checklist

I have added tests that prove my fix is effective or that my feature works

I have updated the CHANGELOG-PENDING file with my change

Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

Specifically, this allows a generated package with a enclosing namespace different then "Pulumi."

github-actions · 2022-01-12T19:01:49Z

Diff for pulumi-random with merge commit 0306cda

github-actions · 2022-01-12T19:01:56Z

Diff for pulumi-azuread with merge commit 0306cda

github-actions · 2022-01-12T19:03:34Z

Diff for pulumi-kubernetes with merge commit 0306cda

github-actions · 2022-01-12T19:06:57Z

Diff for pulumi-gcp with merge commit 0306cda

github-actions · 2022-01-12T19:17:22Z

Diff for pulumi-azure with merge commit 0306cda

github-actions · 2022-01-12T19:24:31Z

Diff for pulumi-aws with merge commit 0306cda

codecov · 2022-01-12T19:25:33Z

Codecov Report

Merging #8735 (2ce445b) into master (a14cd1c) will increase coverage by 0.01%.
The diff coverage is 92.95%.

@@            Coverage Diff             @@
##           master    #8735      +/-   ##
==========================================
+ Coverage   59.38%   59.39%   +0.01%     
==========================================
  Files         637      639       +2     
  Lines       97911    98020     +109     
  Branches     1386     1386              
==========================================
+ Hits        58141    58222      +81     
- Misses      36491    36513      +22     
- Partials     3279     3285       +6

Impacted Files	Coverage Δ
pkg/codegen/dotnet/templates.go	`100.00% <ø> (ø)`
pkg/codegen/internal/test/sdk_driver.go	`78.35% <85.00%> (+0.45%)`	⬆️
pkg/codegen/dotnet/gen.go	`82.46% <93.33%> (+0.10%)`	⬆️
pkg/codegen/dotnet/doc.go	`74.19% <100.00%> (+1.77%)`	⬆️
pkg/codegen/dotnet/importer.go	`44.00% <100.00%> (+14.00%)`	⬆️
pkg/codegen/utilities.go	`62.66% <100.00%> (+1.02%)`	⬆️
pkg/codegen/dotnet/utilities.go	`76.62% <0.00%> (-6.48%)`	⬇️
pkg/codegen/nodejs/gen_program.go	`87.46% <0.00%> (-1.47%)`	⬇️
pkg/codegen/python/gen_program.go	`87.06% <0.00%> (-1.33%)`	⬇️
pkg/codegen/go/gen_program_utils.go	`6.66% <0.00%> (-1.18%)`	⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14cd1c...2ce445b. Read the comment docs.

…e-owners

github-actions · 2022-01-12T19:47:14Z

Diff for pulumi-random with merge commit f7ed4e3

github-actions · 2022-01-12T19:47:45Z

Diff for pulumi-azuread with merge commit f7ed4e3

github-actions · 2022-01-12T19:49:13Z

Diff for pulumi-kubernetes with merge commit f7ed4e3

github-actions · 2022-01-12T19:51:06Z

Diff for pulumi-gcp with merge commit f7ed4e3

github-actions · 2022-01-12T19:59:12Z

Diff for pulumi-random with merge commit 6f16cda

github-actions · 2022-01-12T19:59:35Z

Diff for pulumi-random with merge commit f2fbb8f

github-actions · 2022-01-12T19:59:38Z

Diff for pulumi-azuread with merge commit 6f16cda

github-actions · 2022-01-12T20:00:08Z

Diff for pulumi-kubernetes with merge commit 6f16cda

github-actions · 2022-01-12T20:00:45Z

Diff for pulumi-azuread with merge commit f2fbb8f

github-actions · 2022-01-12T20:00:54Z

Diff for pulumi-azure-native with merge commit 0306cda

github-actions · 2022-01-12T20:01:10Z

Diff for pulumi-azure with merge commit f7ed4e3

github-actions · 2022-01-12T20:02:17Z

Diff for pulumi-kubernetes with merge commit f2fbb8f

github-actions · 2022-01-12T20:03:15Z

Diff for pulumi-gcp with merge commit 6f16cda

github-actions · 2022-01-12T20:06:24Z

Diff for pulumi-gcp with merge commit f2fbb8f

github-actions · 2022-01-12T20:06:24Z

Diff for pulumi-aws with merge commit f7ed4e3

github-actions · 2022-01-20T21:03:11Z

Diff for pulumi-azuread with merge commit dd0b890

github-actions · 2022-01-20T21:04:03Z

Diff for pulumi-kubernetes with merge commit dd0b890

github-actions · 2022-01-20T21:07:38Z

Diff for pulumi-gcp with merge commit dd0b890

github-actions · 2022-01-20T21:18:04Z

Diff for pulumi-azure with merge commit dd0b890

github-actions · 2022-01-20T21:26:00Z

Diff for pulumi-aws with merge commit dd0b890

github-actions · 2022-01-20T21:46:12Z

Diff for pulumi-azure-native with merge commit dd0b890

github-actions · 2022-01-20T22:27:19Z

Diff for pulumi-azuread with merge commit d36fa55

github-actions · 2022-01-20T22:27:46Z

Diff for pulumi-kubernetes with merge commit d36fa55

github-actions · 2022-01-20T22:28:01Z

Diff for pulumi-random with merge commit d36fa55

github-actions · 2022-01-20T22:33:06Z

Diff for pulumi-gcp with merge commit d36fa55

github-actions · 2022-01-20T22:43:55Z

Diff for pulumi-azure with merge commit d36fa55

github-actions · 2022-01-20T22:48:12Z

Diff for pulumi-aws with merge commit d36fa55

github-actions · 2022-01-20T23:20:29Z

Diff for pulumi-azure-native with merge commit d36fa55

t0yv0 · 2022-01-21T16:40:20Z

pkg/codegen/internal/test/testdata/simple-yaml-schema/docs/typeuses/_index.md

    </dt>
    <dd>{{% md %}}{{% /md %}}</dd><dt class="property-optional"
            title="Optional">
        <span id="qux_csharp">
 <a href="#qux_csharp" style="color: inherit; text-decoration: inherit;">Qux</a>
 </span>
        <span class="property-indicator"></span>
-        <span class="property-type"><a href="#rubbertreevariety">Pulumi.<wbr>Example.<wbr>Rubber<wbr>Tree<wbr>Variety</a></span>
+        <span class="property-type"><a href="#rubbertreevariety">.<wbr>Example.<wbr>Rubber<wbr>Tree<wbr>Variety</a></span>


This doesn't look good. .Example? Starting with a dot?

t0yv0 · 2022-01-21T16:42:08Z

pkg/codegen/dotnet/gen.go

@@ -202,7 +205,7 @@ func (mod *modContext) tokenToNamespace(tok string, qualifier string) string {
 	components := strings.Split(tok, ":")
 	contract.Assertf(len(components) == 3, "malformed token %v", tok)

-	pkg, nsName := "Pulumi."+namespaceName(mod.namespaces, components[0]), mod.pkg.TokenToModule(tok)
+	pkg, nsName := mod.rootNamespace+"."+namespaceName(mod.namespaces, components[0]), mod.pkg.TokenToModule(tok)


Perhaps handle the "" case?

Forgot to pipe mod.rootNamespace into the docs generation. Fixed now.

t0yv0

LGTM except something funky around empty namespaces and .Foo refs generated starting with a dot.

github-actions · 2022-01-21T19:53:54Z

Diff for pulumi-azuread with merge commit 58940cd

github-actions · 2022-01-21T19:54:03Z

Diff for pulumi-random with merge commit 58940cd

github-actions · 2022-01-21T19:54:36Z

Diff for pulumi-kubernetes with merge commit 58940cd

github-actions · 2022-01-21T19:58:23Z

Diff for pulumi-gcp with merge commit 58940cd

github-actions · 2022-01-21T20:06:24Z

Diff for pulumi-azure with merge commit 58940cd

github-actions · 2022-01-21T20:15:56Z

Diff for pulumi-aws with merge commit 58940cd

github-actions · 2022-01-21T20:36:42Z

Diff for pulumi-azure-native with merge commit 58940cd

iwahbe added 3 commits January 12, 2022 10:30

Allow .NET packages alternate owners

25b87f8

Specifically, this allows a generated package with a enclosing namespace different then "Pulumi."

New test case files

8b13fe5

Remove unused import

988b5ca

iwahbe self-assigned this Jan 12, 2022

iwahbe requested a review from a team January 12, 2022 19:32

iwahbe added 2 commits January 12, 2022 11:42

Update CHANGELOG_PENDING.md

46b09c1

Merge branch 'master' into iwahbe/8573/allow-dotnet-packages-alternat…

bf745a8

…e-owners

Update codegen from master merge

28a4b9e

Update tests from master

6d30edf

t0yv0 reviewed Jan 21, 2022

View reviewed changes

t0yv0 self-requested a review January 21, 2022 16:42

t0yv0 approved these changes Jan 21, 2022

View reviewed changes

Add rootNamespace to docs

2ce445b

iwahbe merged commit 90913de into master Jan 21, 2022

pulumi-bot deleted the iwahbe/8573/allow-dotnet-packages-alternate-owners branch January 21, 2022 20:58

iwahbe mentioned this pull request Jan 22, 2022

Add providers and root namespace to documentation pulumi/pulumi-hugo#997

Merged

iwahbe mentioned this pull request May 26, 2022

Multi-Languange Component: rootNamespace is ignored when generating C# SDK #9701

Closed

[codegen/dotnet] Allow generated SDKs to have a global namespace other then Pulumi #8735

[codegen/dotnet] Allow generated SDKs to have a global namespace other then Pulumi #8735

Conversation

iwahbe commented Jan 12, 2022 • edited Loading

Description

Checklist

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

codecov bot commented Jan 12, 2022 • edited Loading

Codecov Report

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 12, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

github-actions bot commented Jan 20, 2022

t0yv0 Jan 21, 2022

Choose a reason for hiding this comment

t0yv0 Jan 21, 2022

Choose a reason for hiding this comment

iwahbe Jan 21, 2022 • edited Loading

Choose a reason for hiding this comment

t0yv0 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 21, 2022

github-actions bot commented Jan 21, 2022

github-actions bot commented Jan 21, 2022

github-actions bot commented Jan 21, 2022

github-actions bot commented Jan 21, 2022

github-actions bot commented Jan 21, 2022

github-actions bot commented Jan 21, 2022

[codegen/dotnet] Allow generated SDKs to have a global namespace other then `Pulumi` #8735

[codegen/dotnet] Allow generated SDKs to have a global namespace other then `Pulumi` #8735

iwahbe commented Jan 12, 2022 •

edited

Loading

codecov bot commented Jan 12, 2022 •

edited

Loading

iwahbe Jan 21, 2022 •

edited

Loading