Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk/dotnet] add plugin download url #8739

Merged
merged 23 commits into from Jan 14, 2022
Merged

[sdk/dotnet] add plugin download url #8739

merged 23 commits into from Jan 14, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 12, 2022 •
edited

Description

Fixes #8689

NOTE: Do not merge until.github/workflows/run-build-and-acceptance-tests.yml is changed from test to test-fast.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe
[sdk/dotnet] Add PluginDownloadURL
4c1becc
@iwahbe
Update CHANGELOG_PENDING.md
aa6ddff
@iwahbe
Add dotnet test
680c513
@iwahbe
Merge branch 'master' into iwahbe/8689/dotnet-add-PluginDownloadURL
3eca997
@iwahbe
Set Random resource.remote = false
e08c984
@iwahbe
Add codegen
2d151b8
@iwahbe
Codegen changes to Utilizes.cs
e1e0780
@iwahbe
Fix ResourceOptions.merge
ebf0996
@iwahbe
Remove WithVersion
021b4c0
@iwahbe
Fix local test environment
9807724
@iwahbe
Add WithVersion back (marked as obsolete)
d9994e7
@iwahbe
Fix ResourceOptions.Copy
1b6bc3d
@iwahbe
Merge branch 'master' into iwahbe/8689/dotnet-add-PluginDownloadURL
fac93c0
@iwahbe
Use null coalescence operator
cafa65e
@iwahbe
Set csharp to use projectReferences
ddccb58
@iwahbe
Add PluginDownloadURL to CallOptions
ae4decc
@iwahbe
Populate CallOptions in codegen
e3397e0
@iwahbe
Revert "Populate CallOptions in codegen"
d2487c5 
This reverts commit e3397e0.
@iwahbe
Make backwards compatible with previous sdks
feb7cde
@iwahbe
Run integration tests on MacOS
cec6f18
@iwahbe iwahbe self-assigned this Jan 12, 2022
@github-actions
Copy link

Diff for pulumi-random with merge commit ffdcbaf

@github-actions
Copy link

Diff for pulumi-azuread with merge commit ffdcbaf

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit ffdcbaf

@github-actions
Copy link

Diff for pulumi-gcp with merge commit ffdcbaf

@github-actions
Copy link

Diff for pulumi-azure with merge commit ffdcbaf

@iwahbe iwahbe marked this pull request as draft January 12, 2022 22:51
@github-actions
Copy link

Diff for pulumi-aws with merge commit ffdcbaf

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit ffdcbaf

@codecov
Copy link

codecov bot commented Jan 12, 2022 •
edited

Codecov Report

Merging #8739 (f37297f) into master (48012b5) will increase coverage by 0.01%.
The diff coverage is 83.33%.

❗ Current head f37297f differs from pull request most recent head 7af3aae. Consider uploading reports for the commit 7af3aae to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8739      +/-   ##
==========================================
+ Coverage   59.33%   59.35%   +0.01%     
==========================================
  Files         637      637              
  Lines       97740    97761      +21     
  Branches     1385     1385              
==========================================
+ Hits        57995    58024      +29     
+ Misses      36470    36460      -10     
- Partials     3275     3277       +2
Impacted Files Coverage Δ
pkg/codegen/dotnet/templates.go 100.00% <ø> (ø)
sdk/dotnet/Pulumi/Deployment/CallOptions.cs 0.00% <0.00%> (ø)
sdk/dotnet/Pulumi/Deployment/Deployment_Call.cs 0.00% <0.00%> (ø)
...k/dotnet/Pulumi/Resources/ResourceOptions_Merge.cs 0.00% <0.00%> (ø)
pkg/codegen/dotnet/gen.go 82.35% <100.00%> (+0.02%) ⬆️
pkg/testing/integration/program.go 44.54% <100.00%> (+0.29%) ⬆️
sdk/dotnet/Pulumi/Deployment/Deployment_Invoke.cs 60.49% <100.00%> (+0.49%) ⬆️
...t/Pulumi/Deployment/Deployment_RegisterResource.cs 88.31% <100.00%> (+0.15%) ⬆️
sdk/dotnet/Pulumi/Deployment/InvokeOptions.cs 100.00% <100.00%> (ø)
sdk/dotnet/Pulumi/Resources/Resource.cs 73.36% <100.00%> (+0.13%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48012b5...7af3aae. Read the comment docs.

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 426ebfb

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 426ebfb

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 426ebfb

@github-actions
Copy link

Diff for pulumi-azure with merge commit 426ebfb

@github-actions
Copy link

Diff for pulumi-aws with merge commit 426ebfb

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 426ebfb

@github-actions
Copy link

Diff for pulumi-azuread with merge commit ff25f2e

@github-actions
Copy link

Diff for pulumi-random with merge commit ff25f2e

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit ff25f2e

@github-actions
Copy link

Diff for pulumi-gcp with merge commit ff25f2e

@github-actions
Copy link

Diff for pulumi-azure with merge commit ff25f2e

@github-actions
Copy link

Diff for pulumi-aws with merge commit ff25f2e

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit ff25f2e

@iwahbe iwahbe requested review from t0yv0 and justinvp January 13, 2022 20:53
@iwahbe iwahbe marked this pull request as ready for review January 13, 2022 20:53
t0yv0
t0yv0 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reintroducing it Ian.

t0yv0
t0yv0 reviewed Jan 13, 2022
View reviewed changes
pkg/testing/integration/program.go
err = pt.runCommand("dotnet-add-package",
[]string{dotNetBin, "add", "package", dep, "-v", version, "-s", localNuget}, cwd)
[]string{dotNetBin, "add", "package", dep,
"-v", version,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

@iwahbe iwahbe merged commit 2f04a69 into master Jan 14, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/8689/dotnet-add-PluginDownloadURL branch January 14, 2022 00:10
@github-actions
Copy link

Diff for pulumi-azuread with merge commit a35d90d

@github-actions
Copy link

Diff for pulumi-random with merge commit a35d90d

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit a35d90d

@github-actions
Copy link

Diff for pulumi-gcp with merge commit a35d90d

@github-actions
Copy link

Diff for pulumi-azure with merge commit a35d90d

@github-actions
Copy link

Diff for pulumi-aws with merge commit a35d90d

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit a35d90d

abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
@iwahbe
[sdk/dotnet] add plugin download url (pulumi/pulumi#8739)
c8b4573 
* [sdk/dotnet] Add PluginDownloadURL

* Update CHANGELOG_PENDING.md

* Add dotnet test

* Set Random resource.remote = false

* Add codegen

* Codegen changes to Utilizes.cs

* Fix ResourceOptions.merge

* Remove WithVersion

* Fix local test environment

* Add WithVersion back (marked as obsolete)

* Fix ResourceOptions.Copy

* Use null coalescence operator

* Set csharp to use projectReferences

* Add PluginDownloadURL to CallOptions

* Populate CallOptions in codegen

* Revert "Populate CallOptions in codegen"

This reverts commit e3397e073396271a1fa2c1a594520c822afeda5e.

* Make backwards compatible with previous sdks

* Run integration tests on MacOS

* Attempt to fix macos build error

* Disable full testing suite (MacOS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@justinvp justinvp Awaiting requested review from justinvp

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sdk/dotnet] Support for custom server urls
2 participants
@iwahbe @t0yv0