Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Unify Map and Value number exporting" #8754

Merged
merged 2 commits into from Jan 14, 2022
Merged

Revert "Unify Map and Value number exporting" #8754

merged 2 commits into from Jan 14, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 14, 2022

Reverts #8682

Fixes #8745
Fixes #8752

@iwahbe iwahbe self-assigned this Jan 14, 2022
@iwahbe iwahbe added impact/no-changelog-required This issue doesn't require a CHANGELOG update and removed impact/no-changelog-required This issue doesn't require a CHANGELOG update labels Jan 14, 2022
mikhailshilkov
mikhailshilkov approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for jumping on this! Do you mind adding a changelog entry?

@iwahbe iwahbe merged commit 490873b into master Jan 14, 2022
@pulumi-bot pulumi-bot deleted the revert-8682-iwahbe/8575/consistent-number-handling-in-config branch January 14, 2022 16:10
@mikhailshilkov mikhailshilkov mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhailshilkov mikhailshilkov mikhailshilkov approved these changes

@t0yv0 t0yv0 Awaiting requested review from t0yv0

@Frassle Frassle Awaiting requested review from Frassle

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@iwahbe @mikhailshilkov