[CLI] Allow downloading plugins from GitHub Releases #8785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
force-pushed
the
download-from-ghr
branch
2 times, most recently
from
c3c5e8c
to
f3fe7c3
Compare
Frassle
approved these changes
Jan 19, 2022
| @@ -219,10 +219,10 @@ func interpolateURL(serverURL string, version semver.Version, os, arch string) s | |||
| // Download fetches an io.ReadCloser for this plugin and also returns the size of the response (if known). | |||
| func (info PluginInfo) Download() (io.ReadCloser, int64, error) { | |||
| // Figure out the OS/ARCH pair for the download URL. | |||
| var os string | |||
| var opSy string | |||
There was a problem hiding this comment.
It took me so long to work out this is "op_erating_Sy_stem" 😖
| kind, name, version.String(), opSy, arch))) | ||
| } | ||
|
|
||
| func buildPulumiHostedPluginURL(kind PluginKind, name string, version *semver.Version, opSy, arch string) string { |
There was a problem hiding this comment.
This method is just buildUserSpecifiedPluginURL("https://get.pulumi.com/releases/plugins", kind, name, version, opSy, arch)
| } | ||
| serverURL = interpolateURL(serverURL, *info.Version, os, arch) | ||
|
|
||
| if _, ok := os.LookupEnv("PULUMI_EXPERIMENTAL"); ok { |
Codecov Report
@@ Coverage Diff @@
## master #8785 +/- ##
==========================================
+ Coverage 59.35% 59.39% +0.03%
==========================================
Files 637 637
Lines 97765 97911 +146
Branches 1385 1386 +1
==========================================
+ Hits 58031 58153 +122
- Misses 36461 36477 +16
- Partials 3273 3281 +8
Continue to review full report at Codecov.
|
iwahbe
approved these changes
Jan 19, 2022
| @@ -235,6 +235,49 @@ func TestPluginSelection_EmptyVersionWithAlternatives(t *testing.T) { | |||
| assert.Equal(t, "0.2.0", result.Version.String()) | |||
| } | |||
|
|
|||
| func TestPluginDownloadUrl(t *testing.T) { | |||
There was a problem hiding this comment.
I'd love to see this as a table driven test
There was a problem hiding this comment.
I will be looping back to this code once we make it the default so I will fix these up then just incase it needs to change
Rather than downloading from get.pulumi.com, we now have changed to specify that providers are downloaded from GitHub Releases for all of the official plugins
stack72
force-pushed
the
download-from-ghr
branch
from
f3fe7c3
to
c7ea92a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than downloading from get.pulumi.com, we now have changed to
specify that providers are downloaded from GitHub Releases for
all of the official plugins
Description
Fixes # (issue)
Checklist