Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk/dotnet] Normalize provider providers merge #8838

Merged
merged 7 commits into from
Jan 31, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 26, 2022

Description

Part of #8796.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

This is a placeholder for complete testing
@iwahbe iwahbe self-assigned this Jan 26, 2022
@iwahbe iwahbe marked this pull request as draft January 26, 2022 18:45
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #8838 (f486557) into master (40eee58) will increase coverage by 0.05%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8838      +/-   ##
==========================================
+ Coverage   59.29%   59.35%   +0.05%     
==========================================
  Files         641      641              
  Lines       99377    99403      +26     
  Branches     1389     1389              
==========================================
+ Hits        58930    59001      +71     
+ Misses      37082    37035      -47     
- Partials     3365     3367       +2     
Impacted Files Coverage Δ
sdk/dotnet/Pulumi/Deployment/Deployment_Prepare.cs 77.20% <25.00%> (-8.89%) ⬇️
...otnet/Pulumi/Resources/ComponentResourceOptions.cs 100.00% <100.00%> (+87.50%) ⬆️
sdk/nodejs/automation/localWorkspace.ts 74.03% <0.00%> (-0.39%) ⬇️
pkg/codegen/hcl2/model/type_object.go 89.72% <0.00%> (+0.54%) ⬆️
...k/dotnet/Pulumi/Deployment/TaskMonitoringHelper.cs 100.00% <0.00%> (+3.70%) ⬆️
sdk/go/common/util/ciutil/github_actions.go 73.52% <0.00%> (+38.23%) ⬆️
...k/dotnet/Pulumi/Resources/CustomResourceOptions.cs 100.00% <0.00%> (+64.28%) ⬆️
...k/dotnet/Pulumi/Resources/ResourceOptions_Merge.cs 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40eee58...f486557. Read the comment docs.

@iwahbe iwahbe requested a review from Frassle January 27, 2022 13:49
@iwahbe iwahbe marked this pull request as ready for review January 27, 2022 13:49
@iwahbe iwahbe requested a review from dixler January 28, 2022 11:05
Copy link
Contributor

@dixler dixler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwahbe iwahbe merged commit 2d31b0d into master Jan 31, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/dotnet-normalize-provider-merge-options branch January 31, 2022 11:44
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
* Make MergeComponentResourceOptions change

This is a placeholder for complete testing

* Cleanup code for ComponentResourceOptions

* Remove promotion

* Update for deployment

* Update CHANGELOG_PENDING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants