-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sequence numbers from dynamic providers #8849
Conversation
@@ -158,7 +158,7 @@ export interface Provider { | |||
* @param olds The old input properties to use for validation. | |||
* @param news The new input properties to use for validation. | |||
*/ | |||
check?: (urn: resource.URN, olds: any, news: any, sequenceNumber: number) => Promise<CheckResult>; | |||
check?: (urn: resource.URN, olds: any, news: any) => Promise<CheckResult>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are sequenceNumbers
strictly not needed here? Or should we keep the parameter but make it optional? (which also may avoid the breaking change vs. current master)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think even if it's optional it's a breaking change because when you inherit from the interface you still need to match the parameters. I don't think this is needed in dynamic or node providers yet.
Codecov Report
@@ Coverage Diff @@
## master #8849 +/- ##
==========================================
- Coverage 59.43% 59.39% -0.05%
==========================================
Files 639 639
Lines 98289 98289
Branches 1389 1389
==========================================
- Hits 58421 58375 -46
- Misses 36553 36612 +59
+ Partials 3315 3302 -13
Continue to review full report at Codecov.
|
Description
Remove sequence numbers from the dynamic provider interfaces.
It was a source breaking change adding these to the interface declarations. We don't need sequence numbers yet so this can go in as a 4.0 change.
Fixes #8848
Checklist