Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sequence numbers from dynamic providers #8849

Merged
merged 4 commits into from
Jan 27, 2022
Merged

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Jan 27, 2022

Description

Remove sequence numbers from the dynamic provider interfaces.
It was a source breaking change adding these to the interface declarations. We don't need sequence numbers yet so this can go in as a 4.0 change.

Fixes #8848

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@Frassle Frassle requested a review from a team January 27, 2022 18:45
@@ -158,7 +158,7 @@ export interface Provider {
* @param olds The old input properties to use for validation.
* @param news The new input properties to use for validation.
*/
check?: (urn: resource.URN, olds: any, news: any, sequenceNumber: number) => Promise<CheckResult>;
check?: (urn: resource.URN, olds: any, news: any) => Promise<CheckResult>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are sequenceNumbers strictly not needed here? Or should we keep the parameter but make it optional? (which also may avoid the breaking change vs. current master)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even if it's optional it's a breaking change because when you inherit from the interface you still need to match the parameters. I don't think this is needed in dynamic or node providers yet.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #8849 (7c8e8bd) into master (e0b6798) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8849      +/-   ##
==========================================
- Coverage   59.43%   59.39%   -0.05%     
==========================================
  Files         639      639              
  Lines       98289    98289              
  Branches     1389     1389              
==========================================
- Hits        58421    58375      -46     
- Misses      36553    36612      +59     
+ Partials     3315     3302      -13     
Impacted Files Coverage Δ
sdk/nodejs/dynamic/index.ts 21.05% <ø> (ø)
sdk/nodejs/provider/server.ts 5.01% <0.00%> (ø)
sdk/python/lib/pulumi/dynamic/dynamic.py 53.40% <100.00%> (ø)
pkg/cmd/pulumi/pulumi.go 37.86% <0.00%> (-14.14%) ⬇️
sdk/go/common/workspace/paths.go 72.91% <0.00%> (-2.09%) ⬇️
pkg/backend/httpstate/backend.go 35.93% <0.00%> (-0.53%) ⬇️
pkg/backend/httpstate/client/client.go 38.13% <0.00%> (-0.51%) ⬇️
sdk/nodejs/automation/localWorkspace.ts 74.03% <0.00%> (-0.39%) ⬇️
sdk/go/common/resource/properties.go 83.70% <0.00%> (+0.82%) ⬆️
...k/dotnet/Pulumi/Deployment/TaskMonitoringHelper.cs 100.00% <0.00%> (+3.70%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43587ce...7c8e8bd. Read the comment docs.

@Frassle Frassle mentioned this pull request Jan 27, 2022
18 tasks
@t0yv0 t0yv0 self-requested a review January 27, 2022 20:32
@Frassle Frassle merged commit a584c69 into master Jan 27, 2022
@pulumi-bot pulumi-bot deleted the fraser/rmDynamicSeqNum branch January 27, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change to check in provider type
4 participants