Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program codegen correctly handles foreign imports #8861

Merged
merged 9 commits into from
Jan 31, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 27, 2022

Description

Fixes #8822

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe self-assigned this Jan 27, 2022
@github-actions
Copy link

Diff for pulumi-random with merge commit 2361b8d

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 2361b8d

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 2361b8d

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 2361b8d

@github-actions
Copy link

Diff for pulumi-azure with merge commit 2361b8d

@github-actions
Copy link

Diff for pulumi-aws with merge commit 2361b8d

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 2361b8d

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #8861 (8004672) into master (8ffac5c) will increase coverage by 0.02%.
The diff coverage is 84.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8861      +/-   ##
==========================================
+ Coverage   59.33%   59.36%   +0.02%     
==========================================
  Files         641      641              
  Lines       99407    99407              
  Branches     1389     1389              
==========================================
+ Hits        58986    59014      +28     
+ Misses      37056    37027      -29     
- Partials     3365     3366       +1     
Impacted Files Coverage Δ
pkg/resource/deploy/deploytest/pluginhost.go 65.82% <25.00%> (-0.85%) ⬇️
pkg/codegen/internal/utils/host.go 86.95% <66.66%> (+1.95%) ⬆️
pkg/codegen/dotnet/gen_program.go 89.48% <70.00%> (-0.54%) ⬇️
pkg/codegen/internal/utils/providers.go 75.00% <70.00%> (+17.85%) ⬆️
pkg/codegen/internal/test/program_driver.go 52.70% <71.42%> (+0.64%) ⬆️
pkg/codegen/go/gen_program.go 87.19% <100.00%> (+0.24%) ⬆️
pkg/codegen/nodejs/gen_program.go 87.61% <100.00%> (+0.15%) ⬆️
pkg/codegen/python/gen_program.go 87.80% <100.00%> (+0.73%) ⬆️
pkg/codegen/schema/loader.go 55.37% <100.00%> (+0.75%) ⬆️
sdk/go/common/resource/properties.go 82.87% <0.00%> (-0.83%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ffac5c...8004672. Read the comment docs.

Copy link
Member

@AaronFriel AaronFriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one nit, otherwise looks good.

pkg/codegen/internal/test/testdata/other.json Outdated Show resolved Hide resolved
@github-actions
Copy link

Diff for pulumi-random with merge commit 1236895

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 1236895

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 1236895

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 1236895

@github-actions
Copy link

Diff for pulumi-azure with merge commit 1236895

@github-actions
Copy link

Diff for pulumi-aws with merge commit 1236895

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 1236895

@github-actions
Copy link

Diff for pulumi-azuread with merge commit aefcddd

@github-actions
Copy link

Diff for pulumi-random with merge commit aefcddd

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit aefcddd

@github-actions
Copy link

Diff for pulumi-gcp with merge commit aefcddd

@github-actions
Copy link

Diff for pulumi-azure with merge commit aefcddd

@github-actions
Copy link

Diff for pulumi-aws with merge commit aefcddd

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit aefcddd

Copy link
Member

@AaronFriel AaronFriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwahbe iwahbe merged commit ef2d6ef into master Jan 31, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/8822/programgen-handle-forign-imports branch January 31, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codegen/nodejs] Generate correct import paths for custom packages
2 participants