-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program codegen correctly handles foreign imports #8861
Conversation
This involved extending the third-party test to accommodate modules.
Diff for pulumi-random with merge commit 2361b8d |
Diff for pulumi-azuread with merge commit 2361b8d |
Diff for pulumi-kubernetes with merge commit 2361b8d |
Diff for pulumi-gcp with merge commit 2361b8d |
Diff for pulumi-azure with merge commit 2361b8d |
Diff for pulumi-aws with merge commit 2361b8d |
Diff for pulumi-azure-native with merge commit 2361b8d |
Codecov Report
@@ Coverage Diff @@
## master #8861 +/- ##
==========================================
+ Coverage 59.33% 59.36% +0.02%
==========================================
Files 641 641
Lines 99407 99407
Branches 1389 1389
==========================================
+ Hits 58986 59014 +28
+ Misses 37056 37027 -29
- Partials 3365 3366 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one nit, otherwise looks good.
Diff for pulumi-random with merge commit 1236895 |
Diff for pulumi-azuread with merge commit 1236895 |
Diff for pulumi-kubernetes with merge commit 1236895 |
Diff for pulumi-gcp with merge commit 1236895 |
Diff for pulumi-azure with merge commit 1236895 |
Diff for pulumi-aws with merge commit 1236895 |
Diff for pulumi-azure-native with merge commit 1236895 |
Diff for pulumi-azuread with merge commit aefcddd |
Diff for pulumi-random with merge commit aefcddd |
Diff for pulumi-kubernetes with merge commit aefcddd |
Diff for pulumi-gcp with merge commit aefcddd |
Diff for pulumi-azure with merge commit aefcddd |
Diff for pulumi-aws with merge commit aefcddd |
Diff for pulumi-azure-native with merge commit aefcddd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes #8822
Checklist