Allow replace if either old or new protect is false #8873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8873 +/- ##
==========================================
+ Coverage 59.37% 59.38% +0.01%
==========================================
Files 639 639
Lines 98297 98298 +1
Branches 1389 1389
==========================================
+ Hits 58365 58379 +14
+ Misses 36631 36616 -15
- Partials 3301 3303 +2
Continue to review full report at Codecov.
|
iwahbe
reviewed
Jan 28, 2022
| @@ -604,7 +604,7 @@ func (sg *stepGenerator) generateStepsFromDiff( | |||
| // If this resource is protected we can't replace it because that entails a delete | |||
| // Note that we do allow unprotecting and replacing to happen in a single update | |||
| // cycle, we don't look at old.Protect here. | |||
| if goal.Protect { | |||
There was a problem hiding this comment.
Why change between goal.Protect and new.Protect? Will they always agree?
There was a problem hiding this comment.
Yeh we set new.Protect from goal.Protect higher up in the step generator.
t0yv0
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow a resource to be replaced if either it's old or new state has the protect flag disabled. Importantly this still doesn't allow a resource to be just deleted in the same update operation that disables it's protect flag.
Fixes #8871
Checklist