Respect schema versions (toggled via flag) #8881

@@            Coverage Diff             @@
##           master    #8881      +/-   ##
==========================================
+ Coverage   59.35%   59.41%   +0.05%     
==========================================
  Files         642      642              
  Lines       99555    99651      +96     
  Branches     1389     1389              
==========================================
+ Hits        59093    59203     +110     
+ Misses      37090    37074      -16     
- Partials     3372     3374       +2

Impacted Files	Coverage Δ
pkg/codegen/dotnet/importer.go	`44.00% <ø> (ø)`
pkg/codegen/go/importer.go	`18.75% <ø> (ø)`
pkg/codegen/nodejs/importer.go	`40.00% <ø> (ø)`
pkg/codegen/python/importer.go	`30.00% <ø> (ø)`
pkg/codegen/dotnet/gen.go	`82.52% <100.00%> (+0.06%)`	⬆️
pkg/codegen/go/gen.go	`89.72% <100.00%> (+0.01%)`	⬆️
pkg/codegen/nodejs/gen.go	`84.10% <100.00%> (+0.10%)`	⬆️
pkg/codegen/python/gen.go	`84.37% <100.00%> (+0.07%)`	⬆️
pkg/codegen/python/utilities.go	`92.17% <100.00%> (+8.84%)`	⬆️
pkg/codegen/hcl2/model/type_object.go	`89.72% <0.00%> (+0.54%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 772953d...f8f5cdf. Read the comment docs.

Frassle · 2022-01-31T12:25:52Z

pkg/codegen/dotnet/gen.go

+	}
+
+	if pkg.Version != nil && codegen.RespectVersion() {
+		files.add("version.txt", []byte(pkg.Version.String()))


What is version.txt supposed to be? If we're stamping a version to the codegen'd project should it be stamped into the project.csproj as ?

version.txt is the file we use to check the version of the package (at runtime). It makes some amount of sense to stamp the version into *.csproj.

pkg/codegen/utilities.go

github-actions · 2022-01-31T12:34:40Z

Diff for pulumi-azure-native with merge commit 5eaa476

github-actions · 2022-01-31T12:43:40Z

Diff for pulumi-azure-native with merge commit 678fc2c

pkg/codegen/internal/test/testdata/simple-resource-schema/nodejs/package.json

t0yv0 · 2022-01-31T15:10:56Z

Something going on with tests:

=== Failed
=== FAIL: codegen/dotnet TestGeneratePackage/simple-resource-schema (0.00s)
    sdk_driver.go:367: Simple schema with local resource properties
    sdk_driver.go:386: 
        	Error Trace:	sdk_driver.go:386
        	Error:      	Received unexpected error:
        	            	Failed to load file version.txt referenced in codegen-manifest.json: open ../internal/test/testdata/simple-resource-schema/dotnet/version.txt: no such file or directory
        	Test:       	TestGeneratePackage/simple-resource-schema
    --- FAIL: TestGeneratePackage/simple-resource-schema (0.00s)

=== FAIL: codegen/dotnet TestGeneratePackage (181.51s)

Perhaps the version.txt was not checked in?

t0yv0

Left a few comments but generally this looks quite useful - LGTM!

github-actions · 2022-01-31T18:44:21Z

Diff for pulumi-azuread with merge commit 77fd427

github-actions · 2022-01-31T18:44:44Z

Diff for pulumi-random with merge commit 77fd427

github-actions · 2022-01-31T18:47:05Z

Diff for pulumi-kubernetes with merge commit 77fd427

github-actions · 2022-01-31T18:47:22Z

Diff for pulumi-gcp with merge commit 77fd427

github-actions · 2022-01-31T18:53:52Z

Diff for pulumi-azure with merge commit 77fd427

github-actions · 2022-01-31T18:55:52Z

Diff for pulumi-aws with merge commit 77fd427

github-actions · 2022-01-31T19:46:37Z

Diff for pulumi-azure-native with merge commit 77fd427

github-actions · 2022-01-31T20:46:26Z

Diff for pulumi-azuread with merge commit e9a00d7

github-actions · 2022-01-31T20:46:36Z

Diff for pulumi-random with merge commit e9a00d7

github-actions · 2022-01-31T20:48:16Z

Diff for pulumi-kubernetes with merge commit e9a00d7

github-actions · 2022-01-31T20:49:26Z

Diff for pulumi-gcp with merge commit e9a00d7

github-actions · 2022-01-31T20:53:22Z

Diff for pulumi-azure with merge commit e9a00d7

github-actions · 2022-01-31T20:59:08Z

Diff for pulumi-aws with merge commit e9a00d7

github-actions · 2022-01-31T21:30:38Z

Diff for pulumi-azure-native with merge commit e9a00d7

justinvp

LGTM otherwise

pkg/codegen/nodejs/gen.go

pkg/codegen/dotnet/gen.go

stack72

This is a great way to roll out new functionality - opt-in to start with. As this is off by default, I can't see any issues here!

github-actions · 2022-02-03T14:22:31Z

Diff for pulumi-azuread with merge commit 67d6910

github-actions · 2022-02-03T14:23:09Z

Diff for pulumi-random with merge commit 67d6910

github-actions · 2022-02-03T14:24:22Z

Diff for pulumi-kubernetes with merge commit 67d6910

github-actions · 2022-02-03T14:26:33Z

Diff for pulumi-gcp with merge commit 67d6910

github-actions · 2022-02-03T14:32:56Z

Diff for pulumi-azure with merge commit 67d6910

github-actions · 2022-02-03T14:33:07Z

Diff for pulumi-aws with merge commit 67d6910

github-actions · 2022-02-03T15:09:27Z

Diff for pulumi-azure-native with merge commit 67d6910

iwahbe added 3 commits January 31, 2022 12:10

Add version (when env var is set)

afae17f

Correct python pypi implementation

54c476e

Add a test

50bdf44

iwahbe requested review from t0yv0, stack72 and justinvp January 31, 2022 11:37

iwahbe self-assigned this Jan 31, 2022

Update CHANGELOG_PENDING.md

f9fdcd9

iwahbe mentioned this pull request Jan 31, 2022

Respect versions from schema #8105

Closed

3 tasks

Frassle reviewed Jan 31, 2022

View reviewed changes

mikhailshilkov reviewed Jan 31, 2022

View reviewed changes

pkg/codegen/internal/test/testdata/simple-resource-schema/nodejs/package.json Show resolved Hide resolved

iwahbe requested review from Frassle and mikhailshilkov January 31, 2022 13:57

t0yv0 approved these changes Jan 31, 2022

View reviewed changes

Remove version.txt from .gitignore

48f79cb

justinvp approved these changes Feb 2, 2022

View reviewed changes

pkg/codegen/nodejs/gen.go Outdated Show resolved Hide resolved

pkg/codegen/dotnet/gen.go Show resolved Hide resolved

stack72 approved these changes Feb 3, 2022

View reviewed changes

iwahbe added 3 commits February 3, 2022 15:02

Add go support

bca7449

Correctly handle nodejs.pluginVersion

ff7eabc

Merge branch 'master' into iwahbe/respect-versions-v3

f8f5cdf

iwahbe merged commit f2d8858 into master Feb 3, 2022

pulumi-bot deleted the iwahbe/respect-versions-v3 branch February 3, 2022 16:07

hliuson mentioned this pull request Jun 7, 2022

Add Documentation for RespectSchemaVersion pulumi/pulumi-hugo#1596

Merged

Respect schema versions (toggled via flag) #8881

Respect schema versions (toggled via flag) #8881

Conversation

iwahbe commented Jan 31, 2022 • edited

Description

Checklist

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

codecov bot commented Jan 31, 2022 • edited

Codecov Report

Frassle Jan 31, 2022

Choose a reason for hiding this comment

iwahbe Jan 31, 2022

Choose a reason for hiding this comment

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

t0yv0 commented Jan 31, 2022

t0yv0 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

github-actions bot commented Jan 31, 2022

justinvp left a comment

Choose a reason for hiding this comment

stack72 left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 3, 2022

github-actions bot commented Feb 3, 2022

github-actions bot commented Feb 3, 2022

github-actions bot commented Feb 3, 2022

github-actions bot commented Feb 3, 2022

github-actions bot commented Feb 3, 2022

github-actions bot commented Feb 3, 2022

iwahbe commented Jan 31, 2022 •

edited

codecov bot commented Jan 31, 2022 •

edited