-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect schema versions (toggled via flag) #8881
Conversation
Diff for pulumi-random with merge commit 5eaa476 |
Diff for pulumi-azuread with merge commit 5eaa476 |
Diff for pulumi-gcp with merge commit 5eaa476 |
Diff for pulumi-kubernetes with merge commit 5eaa476 |
Diff for pulumi-azuread with merge commit 678fc2c |
Diff for pulumi-random with merge commit 678fc2c |
Diff for pulumi-azure with merge commit 5eaa476 |
Diff for pulumi-kubernetes with merge commit 678fc2c |
Diff for pulumi-gcp with merge commit 678fc2c |
Diff for pulumi-azure with merge commit 678fc2c |
Diff for pulumi-aws with merge commit 5eaa476 |
Diff for pulumi-aws with merge commit 678fc2c |
Codecov Report
@@ Coverage Diff @@
## master #8881 +/- ##
==========================================
+ Coverage 59.35% 59.41% +0.05%
==========================================
Files 642 642
Lines 99555 99651 +96
Branches 1389 1389
==========================================
+ Hits 59093 59203 +110
+ Misses 37090 37074 -16
- Partials 3372 3374 +2
Continue to review full report at Codecov.
|
} | ||
|
||
if pkg.Version != nil && codegen.RespectVersion() { | ||
files.add("version.txt", []byte(pkg.Version.String())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is version.txt supposed to be? If we're stamping a version to the codegen'd project should it be stamped into the project.csproj as ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version.txt
is the file we use to check the version of the package (at runtime). It makes some amount of sense to stamp the version into *.csproj
.
Diff for pulumi-azure-native with merge commit 5eaa476 |
Diff for pulumi-azure-native with merge commit 678fc2c |
pkg/codegen/internal/test/testdata/simple-resource-schema/nodejs/package.json
Show resolved
Hide resolved
Something going on with tests:
Perhaps the version.txt was not checked in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but generally this looks quite useful - LGTM!
Diff for pulumi-azuread with merge commit 77fd427 |
Diff for pulumi-random with merge commit 77fd427 |
Diff for pulumi-kubernetes with merge commit 77fd427 |
Diff for pulumi-gcp with merge commit 77fd427 |
Diff for pulumi-azure with merge commit 77fd427 |
Diff for pulumi-aws with merge commit 77fd427 |
Diff for pulumi-azure-native with merge commit 77fd427 |
Diff for pulumi-azuread with merge commit e9a00d7 |
Diff for pulumi-random with merge commit e9a00d7 |
Diff for pulumi-kubernetes with merge commit e9a00d7 |
Diff for pulumi-gcp with merge commit e9a00d7 |
Diff for pulumi-azure with merge commit e9a00d7 |
Diff for pulumi-aws with merge commit e9a00d7 |
Diff for pulumi-azure-native with merge commit e9a00d7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great way to roll out new functionality - opt-in to start with. As this is off by default, I can't see any issues here!
Diff for pulumi-azuread with merge commit 67d6910 |
Diff for pulumi-random with merge commit 67d6910 |
Diff for pulumi-kubernetes with merge commit 67d6910 |
Diff for pulumi-gcp with merge commit 67d6910 |
Diff for pulumi-azure with merge commit 67d6910 |
Diff for pulumi-aws with merge commit 67d6910 |
Diff for pulumi-azure-native with merge commit 67d6910 |
Description
Fixes #8521
Checklist