re-enable and color dot spinner for non-interactive mode #8996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
approved these changes
Feb 15, 2022
dixler
changed the title
Frassle
approved these changes
Feb 15, 2022
| prefix string | ||
| hasWritten bool | ||
| } | ||
|
|
||
| func (spin *dotSpinner) Tick() { | ||
| if !spin.hasWritten { | ||
| fmt.Print(spin.prefix) | ||
| fmt.Print(spin.color.Colorize(colors.Yellow + spin.prefix)) |
There was a problem hiding this comment.
Why yellow? Does that match something else?
There was a problem hiding this comment.
@susanev suggested it to help contrast from resource creations in white.
There was a problem hiding this comment.
I should probably add a reset here and then manually color it inside the printf down here just in case things get interrupted and we mess up a terminal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The non-interactive dot spinner functionality was not being triggered due to Interactive == true checks in calling functions.
also added color to match the output style
Fixes #6574
Checklist