New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codegen/go] Add GenerateProgramWithOpts function #8997
Conversation
Diff for pulumi-azuread with merge commit 584dd67 |
Diff for pulumi-random with merge commit 584dd67 |
Add an additional function to enable configurable codegen options.
3069257
to
f4e252a
Compare
Diff for pulumi-kubernetes with merge commit 584dd67 |
Diff for pulumi-gcp with merge commit 584dd67 |
Diff for pulumi-random with merge commit 7a3f038 |
Diff for pulumi-azuread with merge commit 7a3f038 |
Diff for pulumi-kubernetes with merge commit 7a3f038 |
Diff for pulumi-gcp with merge commit 7a3f038 |
Diff for pulumi-azure with merge commit 584dd67 |
Diff for pulumi-aws with merge commit 584dd67 |
Diff for pulumi-azure with merge commit 7a3f038 |
Diff for pulumi-aws with merge commit 7a3f038 |
Diff for pulumi-azure-native with merge commit 584dd67 |
Diff for pulumi-azure-native with merge commit 7a3f038 |
Diff for pulumi-random with merge commit 69e9540 |
Diff for pulumi-azuread with merge commit 69e9540 |
Diff for pulumi-kubernetes with merge commit 69e9540 |
Diff for pulumi-gcp with merge commit 69e9540 |
Diff for pulumi-azure with merge commit 69e9540 |
Diff for pulumi-aws with merge commit 69e9540 |
Diff for pulumi-random with merge commit a5162a2 |
Diff for pulumi-azuread with merge commit a5162a2 |
Diff for pulumi-azuread with merge commit cd98745 |
Diff for pulumi-random with merge commit cd98745 |
Diff for pulumi-kubernetes with merge commit a5162a2 |
Diff for pulumi-kubernetes with merge commit cd98745 |
Diff for pulumi-gcp with merge commit cd98745 |
Diff for pulumi-gcp with merge commit a5162a2 |
Diff for pulumi-azure with merge commit a5162a2 |
Diff for pulumi-azure with merge commit cd98745 |
Diff for pulumi-aws with merge commit a5162a2 |
Diff for pulumi-aws with merge commit cd98745 |
Diff for pulumi-azure-native with merge commit 69e9540 |
Diff for pulumi-azure-native with merge commit a5162a2 |
Diff for pulumi-azure-native with merge commit cd98745 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (aside from some nits)
Diff for pulumi-random with merge commit 91e0427 |
Diff for pulumi-azuread with merge commit 91e0427 |
Diff for pulumi-azuread with merge commit da4e8a9 |
Diff for pulumi-random with merge commit da4e8a9 |
Diff for pulumi-kubernetes with merge commit 91e0427 |
Diff for pulumi-kubernetes with merge commit da4e8a9 |
Diff for pulumi-gcp with merge commit 91e0427 |
Diff for pulumi-gcp with merge commit da4e8a9 |
Diff for pulumi-azure with merge commit da4e8a9 |
Diff for pulumi-azure with merge commit 91e0427 |
Diff for pulumi-aws with merge commit da4e8a9 |
Diff for pulumi-aws with merge commit 91e0427 |
Diff for pulumi-azure-native with merge commit 91e0427 |
Diff for pulumi-azure-native with merge commit da4e8a9 |
Description
Add an additional function to enable configurable codegen options.
Here's an example of the generated Go code with this change:
Note that this code currently won't compile due to an unused variable. We could generate a block of code like this if we wanted to guarantee that it compiles:
Fixes # (issue)
Checklist