Add a --generate-code flag to import #9141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
approved these changes
Mar 8, 2022
| if err != nil { | ||
| return result.FromError(err) | ||
| } | ||
| if generateCode { |
There was a problem hiding this comment.
Minor nit: maybe pull the body of this if out into its own function? Normally I'd suggest using an early return here to be more idiomatic and avoid the rightward movement, but that isn't convenient with the res != nil bits later.
There was a problem hiding this comment.
I'd generally lean towards keeping the code inline here, we're just hitting 120 cols which doesn't seem unreasonable.
iwahbe
reviewed
Mar 8, 2022
iwahbe
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a flag
--generate-codeto pulumi import. By default this is true, but users can pass--generate-code=falseto skip the code generation step of import.Fixes #9134
Checklist