Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message in pulumi new #9156

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Fix error message in pulumi new #9156

merged 3 commits into from
Mar 9, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Mar 9, 2022

Description

When running with --yes and letting pulumi select the default project name if it was invalid you got an error message like:
Sorry, '' is not a valid project name.

This fixes that case to instead return the actual project name that caused the issue.

Fixes #8747

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

When running with --yes and letting pulumi select the default project name if it was invalid you got an error message like:
`Sorry, '' is not a valid project name.`

This fixes that case to instead return the actual project name that caused the issue.
@Frassle Frassle requested review from mikhailshilkov and iwahbe and removed request for mikhailshilkov and iwahbe March 9, 2022 14:43
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Frassle Frassle merged commit 107c0b7 into master Mar 9, 2022
@pulumi-bot pulumi-bot deleted the fraser/fixProjectNameError branch March 9, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants