Stop using Get/SetRootResource in dotnet #9515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to use this engine call in dotnet, the engine address and the root stack resource are both global variables. No point roundtripping through the engine.
Zaid-Ajaj
approved these changes
May 3, 2022
3 tasks
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
* Stop using Get/SetRootResource in dotnet There's no reason to use this engine call in dotnet, the engine address and the root stack resource are both global variables. No point roundtripping through the engine. * Add to CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's no reason to use this engine call in dotnet, the engine address and the root stack resource are both global variables. No point roundtripping through the engine.
Plan is to also remove this from nodejs (node does have true global variables, so we'll just use that) and then eventually kill this from the engine (probably a 4.0 change).
Checklist