Send smart aliases via gRPC to engine #9731

Frassle · 2022-05-30T15:51:20Z

Description

This add an new field on the RegisterResource and ReadResource protobuf messages to the resource monitor. As well as the repeated string aliases field, we now have a repeated Alias smartAliases field (name open to scrutiny). The Alias object is a protobuf encoding to match the alias objects we have in the SDKs where users can just set "name", or "type". Those objects worked by the SDK then resolving down to a URN, that resolution logic is now also in the engine and so eventually we'll be able to remove all that logic from every SDK (we can't remove it straight away because of back compatibility, a user may have a new SDK but old engine).

Fixes #9734

Checklist

I have added tests that prove my fix is effective or that my feature works

I have updated the CHANGELOG-PENDING file with my change

Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

Frassle · 2022-06-14T08:35:21Z

/run-integration-tests

github-actions · 2022-06-14T08:35:58Z

Please view the results of the PR Build + Acceptance Tests Run Here

Frassle · 2022-06-14T12:37:36Z

/run-integration-tests

github-actions · 2022-06-14T12:38:15Z

Please view the results of the PR Build + Integration Tests Run Here

AaronFriel · 2022-06-15T19:05:24Z

Curious how big of a change in the engine would it be to rename the existing field (keeping tag ID the same) to alias_urns and naming the new field aliases? I believe protobufs allow these sort of renames as the thing that matters are the type and tag numbers?

I'd then add a [deprecated = true] to the old field, which is a no-op in most languages but might add an annotation or IDE hint.

Frassle · 2022-06-15T21:18:12Z

Curious how big of a change in the engine would it be to rename the existing field (keeping tag ID the same) to alias_urns and naming the new field aliases? I believe protobufs allow these sort of renames as the thing that matters are the type and tag numbers?

I'd then add a [deprecated = true] to the old field, which is a no-op in most languages but might add an annotation or IDE hint.

Done. Interestingly a discovery fell out of that rename that we didn't look at aliases for resource reads, and only the Go SDK tried to send them. I'm not sure if aliases make sense for reads anyway so I've just removed that field for now.

Would be good to get @pgavlin check on if alias for reads is/isn't needed.

AaronFriel

My only comment is that this makes me long for codegen-ing resource options. It's a lot of little changes to review in each SDK.

Looking forward to deleting "inheritedChildAlias" and all the other machinery in the SDKs in 4.0.

AaronFriel · 2022-06-16T00:29:17Z

pkg/resource/deploy/deploytest/resourcemonitor.go

@@ -104,6 +104,7 @@ type ResourceOptions struct {
 	Remote                  bool
 	Providers               map[string]string
 	AdditionalSecretOutputs []resource.PropertyKey
+	SmartAliases            []resource.Alias


Able to rename this field as well?

Frassle · 2022-06-16T07:20:32Z

My only comment is that this makes me long for codegen-ing resource options. It's a lot of little changes to review in each SDK.

Working on a design for that today 😄

Able to rename this field as well?

Yes will do!

AaronFriel · 2022-06-16T19:35:54Z

LGTM

This reverts commit cba1880.

* Revert "Send smart aliases via gRPC to engine (#9731)" This reverts commit cba1880. * Just fully revert the protobuf changes * Add to CHANGELOG

* Send smart aliases via gRPC to engine * Add to SupportsFeature * Restore old logic when the engine doesn't support smartAliases * Add to deploytest ResourceOptions * Add tests * Add to CHANGELOG * Fix test * Rename proto fields * Regenerate protobufs * Fix up SDKs after field rename * Rename deploytest aliases * Rename internal fields * Fix typo in c# code * Fix typescript * Rename feature to aliasSpecs * Rename type to Spec

…ulumi/pulumi#9999) * Revert "Send smart aliases via gRPC to engine (pulumi/pulumi#9731)" This reverts commit c58062b. * Just fully revert the protobuf changes * Add to CHANGELOG

Frassle added 5 commits May 30, 2022 16:12

Send smart aliases via gRPC to engine

15351e9

Merge remote-tracking branch 'origin/master' into smartAlias

f4ae531

Add to SupportsFeature

89220be

Restore old logic when the engine doesn't support smartAliases

8fc9be1

Merge remote-tracking branch 'origin/master' into smartAlias

d821c6d

Merge remote-tracking branch 'origin/master' into smartAlias

250b02f

Frassle added 3 commits June 15, 2022 10:02

Add to deploytest ResourceOptions

e24bb5d

Add tests

e049a8a

Add to CHANGELOG

ed3d32c

Frassle marked this pull request as ready for review June 15, 2022 09:22

Frassle requested review from AaronFriel and Zaid-Ajaj June 15, 2022 09:23

Fix test

b4902fa

Frassle added 3 commits June 15, 2022 22:03

Rename proto fields

6b09350

Regenerate protobufs

fe64e5f

Fix up SDKs after field rename

ad0dfa8

Merge remote-tracking branch 'origin/master' into smartAlias

7172218

AaronFriel approved these changes Jun 16, 2022

View reviewed changes

Frassle added 2 commits June 16, 2022 09:41

Rename deploytest aliases

bf54425

Rename internal fields

6f93f39

Frassle mentioned this pull request Jun 16, 2022

Support aliases for resource reads #9875

Open

Frassle added 2 commits June 16, 2022 10:00

Fix typo in c# code

a836186

Fix typescript

3a55cdd

Frassle added 2 commits June 16, 2022 20:06

Rename feature to aliasSpecs

28c0dc3

Rename type to Spec

7ca71a2

Frassle merged commit cba1880 into master Jun 16, 2022

pulumi-bot deleted the fraser/engineAlias branch June 16, 2022 21:07

Frassle added a commit that referenced this pull request Jun 29, 2022

Revert "Send smart aliases via gRPC to engine (#9731)"

87a5a35

This reverts commit cba1880.

Frassle added a commit that referenced this pull request Jun 29, 2022

Revert "Send smart aliases via gRPC to engine (#9731)" (#9999)

09d6751

* Revert "Send smart aliases via gRPC to engine (#9731)" This reverts commit cba1880. * Just fully revert the protobuf changes * Add to CHANGELOG

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send smart aliases via gRPC to engine #9731

Send smart aliases via gRPC to engine #9731

Frassle commented May 30, 2022 •

edited

Frassle commented Jun 14, 2022

github-actions bot commented Jun 14, 2022

Frassle commented Jun 14, 2022

github-actions bot commented Jun 14, 2022

AaronFriel commented Jun 15, 2022 •

edited

Frassle commented Jun 15, 2022

AaronFriel left a comment

AaronFriel Jun 16, 2022

Frassle commented Jun 16, 2022

AaronFriel commented Jun 16, 2022

Send smart aliases via gRPC to engine #9731

Send smart aliases via gRPC to engine #9731

Conversation

Frassle commented May 30, 2022 • edited

Description

Checklist

Frassle commented Jun 14, 2022

github-actions bot commented Jun 14, 2022

Frassle commented Jun 14, 2022

github-actions bot commented Jun 14, 2022

AaronFriel commented Jun 15, 2022 • edited

Frassle commented Jun 15, 2022

AaronFriel left a comment

Choose a reason for hiding this comment

AaronFriel Jun 16, 2022

Choose a reason for hiding this comment

Frassle commented Jun 16, 2022

AaronFriel commented Jun 16, 2022

Frassle commented May 30, 2022 •

edited

AaronFriel commented Jun 15, 2022 •

edited