[sdk/go] Ensure stackref getters localize secret-ness to the key retrieved #9842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFriel
commented
Jun 10, 2022
AaronFriel
commented
Jun 10, 2022
iwahbe
approved these changes
Jun 14, 2022
sdk/go/pulumi/stack_reference.go
Outdated
| if secret { | ||
| ret = ToSecret(ret) | ||
| } | ||
| return Any(ret), nil |
There was a problem hiding this comment.
This is all conflict with #9855. 😄
There was a problem hiding this comment.
Yours looked good, I tested the nonexistant key behavior, merged & then included tests in this PR :)
AaronFriel
force-pushed
the
friel/9564
branch
3 times, most recently
from
1068499
to
4ff9424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9564