allow pulumi destroy -s <stack> if not in a pulumi project dir
#9918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
June 21, 2022 06:59
…i project directory
|
/run-integration-tests |
|
Please view the results of the PR Build + Integration Tests Run Here |
dixler
commented
Jun 22, 2022
| sm, err := getStackSecretsManager(s) | ||
| if err != nil { | ||
| return result.FromError(fmt.Errorf("getting secrets manager: %w", err)) | ||
| // fallback on snapshot SecretsManager | ||
| sm = snap.SecretsManager | ||
| } | ||
|
|
||
| cfg, err := getStackConfiguration(s, sm) |
dixler
force-pushed
the
dixler/2440/destroy-stack-specifier
branch
from
efb0bb8
to
dd33c7b
Compare
t0yv0
reviewed
Jun 27, 2022
| @@ -171,7 +171,8 @@ func GetEnvironmentTagsForCurrentStack() (map[apitype.StackTagName]string, error | |||
| // Tags based on Pulumi.yaml. | |||
| projPath, err := workspace.DetectProjectPath() | |||
| if err != nil { | |||
| return nil, err | |||
| // No current stack return empty | |||
| return make(map[apitype.StackTagName]string), nil | |||
There was a problem hiding this comment.
This swallows err perhaps a change to log it instead? Slightly suspicious here
workspace.DetectProjectPath() may return "", nil which does return GetEnvironmentTagsForCurrentStack = empty even before the changes, but the change is still needed to ignore an error. What's the error?
There was a problem hiding this comment.
will think more on this.
|
I've re-tested the example that used to panic. And it passes on top of the latest changes. So that's good. Changes LGTM. Do you know what's going on with the failing CI? Also would need a CHANGELOG entry. Thank you. |
t0yv0
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
second time's the charm
Fixes #2440
Checklist