[codegen/go] Support foreign enum types #9920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
requested review from
dixler,
nimbinatus and
t0yv0
and removed request for
nimbinatus
|
Please view the results of the Downstream Codegen Tests Here |
|
Please view the results of the Downstream Codegen Tests Here |
t0yv0
reviewed
Jun 22, 2022
| switch t := t.(type) { | ||
| case *schema.OptionalType: | ||
| pkg.getTypeImports(t.ElementType, recurse, importsAndAliases, seen) | ||
| case *schema.InputType: | ||
| pkg.getTypeImports(t.ElementType, recurse, importsAndAliases, seen) | ||
| case *schema.EnumType: | ||
| if importExternal(t.Token) { |
There was a problem hiding this comment.
Isn't the line immediately below it try to handle externals also?
mod := pkg.tokenToPackage(t.Token)
if mod != pkg.mod // here
I wonder if that is now redundant (dead code)?
There was a problem hiding this comment.
It shouldn't be. Notice that we are comparing mod instead of pkg. This is us handling enums from other modules (but the same pkg). When we check for external, we compare via pkg:
Lines 607 to 608 in 35461be
t0yv0
reviewed
Jun 22, 2022
| TypeLocalInsteadOfRemoteAlias gcpiamv1.AuditConfig `pulumi:"typeLocalInsteadOfRemoteAlias"` | ||
| TypeNoAlias s3.BucketWebsite `pulumi:"typeNoAlias"` | ||
| TypeRemoteAlias dns.DnsKeySpec `pulumi:"typeRemoteAlias"` | ||
| TypeRemoteEnum *accesscontextmanager.DevicePolicyAllowedDeviceManagementLevelsItem `pulumi:"typeRemoteEnum"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9916
Checklist