Add Warnings when Resource Options are applied to Components with no effect #9921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieMcKinstry
added
kind/enhancement
RobbieMcKinstry
changed the title
Frassle
reviewed
Jun 22, 2022
There was a problem hiding this comment.
lint is failing, you need a t.Parallel() inside the cases for loop:
engine/lifeycletest/pulumi_test.go:5365:2: Range statement for test TestComponentOptionWarnings missing the call to method parallel in test Run (paralleltest)
for i, testCase := range cases {
|
I should probably rebase this after the release. It's probably fine and unlikely to introduce a merge conflict in |
RobbieMcKinstry
force-pushed
the
rmckinstry/#9877
branch
from
3d3b7f4
to
5f2e819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-on to #9863. There are some resource options that have no effect when applied to component resources. This PR will produce a warning each time those options are applied to components.
The initial PR was scoped to emit a warning for the
ignoreChangesoption, while this PR addresses resource optionscustomTimeouts,additinoalSecretOutputs,replaceOnChanges, andretainOnDeleteas well.Fixes #9877
Checklist