registry package pages #1797

sean1588 · 2022-12-07T01:40:25Z

issues:
#1531 - create package card
#1705 - compact card alerts
#1702 - H1s for API Docs
#1703 - H1s match selected tabs

figma designs:
https://www.figma.com/file/bVEoSwAvU7KDpuPNri332F/Compact-Registry?node-id=117%3A3379&t=aHUxQCTiyRaFs11P-0
https://www.figma.com/file/bVEoSwAvU7KDpuPNri332F/Compact-Registry?node-id=227%3A5397&t=3sCE2WZGUSX9Dm5q-0

github-actions · 2022-12-07T22:27:36Z

Your site preview for commit ae2d477 is ready! 🎉

http://registry-origin-pr-1797-ae2d4770.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-07T22:49:56Z

Your site preview for commit 6a1b92c is ready! 🎉

http://registry-origin-pr-1797-6a1b92c4.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

anita-trimbur · 2022-12-07T23:20:51Z

aahhh so exciting!! so glad to see this come together

a few minor style nits for the card itself:

the font and size of every element on the open card should be Inter 12px
the only font that's different is the "last published" on the collapsed card which is Inter 10px gray600#5A5A5A
(this is my bad, it's wrong in figma) we should use blue600 #4D5BD9 for that info icon to match the note containers
the info icon and the github icon should be the same size -- i think without the padding it'll be about 15x15
i'm pretty sure the border color is a little light on the open card, should be gray300 #DCDCDC. on the closed card it's gray400 #B0B0B0 along with the down/up chevron

and some things from our slack thread:

we can drop the font size of the breadcrumbs to 14px on tablet and 12px on mobile
we would also like to include the version # on the collapsed card. the format would be v1.13.0, Dec 5 22

sean1588 · 2022-12-07T23:38:23Z

awesome. thanks @anita-trimbur. I'll get those changes made!

github-actions · 2022-12-08T01:11:22Z

Your site preview for commit fdd2ef2 is ready! 🎉

http://registry-origin-pr-1797-fdd2ef2e.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-08T01:11:57Z

Your site preview for commit 8ea9e15 is ready! 🎉

http://registry-origin-pr-1797-8ea9e156.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-08T01:26:14Z

Your site preview for commit a71091b is ready! 🎉

http://registry-origin-pr-1797-a71091b0.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-08T02:12:11Z

Your site preview for commit 6ed5db3 is ready! 🎉

http://registry-origin-pr-1797-6ed5db31.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

anita-trimbur · 2022-12-08T15:36:31Z

wow you got those changes in fast!

additional nit: can we shrink that external link icon by the source code repo down to 12x12. i think that link text can also be 12px

anita-trimbur · 2022-12-08T17:43:02Z

following up on our team discussion regarding grays. here's the breakdown

tailwind is using the blue-grays that we were trying to get rid of. the _colors.scss file nearly matches the service grays in figma with the exception of gray 200, so it shouldn't be problematic to align gray200 as #EFEFEF. i think the difference in border color on the collapsed card was a color sampling error i made in figma -- sean you're right that it should match gray300 as it is defined in the service/.scss file.

susanev · 2022-12-08T18:05:51Z

@anita-trimbur lets leave 200 as is in the _colors file for now, but get the rest of them updated to match the service ones.

github-actions · 2022-12-08T20:35:32Z

Your site preview for commit 3854603 is ready! 🎉

http://registry-origin-pr-1797-3854603b.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-08T20:49:02Z

Your site preview for commit 2398563 is ready! 🎉

http://registry-origin-pr-1797-23985638.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-08T21:15:49Z

Your site preview for commit c644ee3 is ready! 🎉

http://registry-origin-pr-1797-c644ee31.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-08T21:45:15Z

Your site preview for commit 543462d is ready! 🎉

http://registry-origin-pr-1797-543462d0.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-09T00:50:05Z

Your site preview for commit 45c00b5 is ready! 🎉

http://registry-origin-pr-1797-45c00b57.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-09T00:51:17Z

Your site preview for commit bfa2101 is ready! 🎉

http://registry-origin-pr-1797-bfa2101e.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-09T01:10:06Z

Your site preview for commit 15853fb is ready! 🎉

http://registry-origin-pr-1797-15853fba.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-09T21:53:10Z

Your site preview for commit 67e6598 is ready! 🎉

http://registry-origin-pr-1797-67e65982.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-09T22:06:37Z

Your site preview for commit c28549e is ready! 🎉

http://registry-origin-pr-1797-c28549e2.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-09T22:10:58Z

Your site preview for commit 8b5e875 is ready! 🎉

http://registry-origin-pr-1797-8b5e8752.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

anita-trimbur

🚀🚀🚀

kimberleyamackenzie

Amazing!! 🎉 🚢

kimberleyamackenzie · 2022-12-12T18:36:06Z

themes/default/layouts/partials/registry/package/package-alert.html

@@ -0,0 +1,37 @@
+{{ $package := .Scratch.Get "package" }}


TIL about scratch!

i just learned about it too 🙂

github-actions · 2022-12-12T18:41:57Z

Your site preview for commit bbcb4b7 is ready! 🎉

http://registry-origin-pr-1797-bbcb4b73.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

wip wip

github-actions · 2022-12-12T18:56:56Z

Your site preview for commit 72d610b is ready! 🎉

http://registry-origin-pr-1797-72d610b7.s3-website.us-west-2.amazonaws.com/registry.

Registry site previews only include API docs for the AWS and Aiven packages by default. You will not be able to navigate to other docs from the preview link. To see those docs, the PR author can add the desired package name to the list in scripts/ci/build.sh. How-to guides for all packages are also incomplete.

github-actions · 2022-12-12T19:14:18Z

Site previews for this pull request have been removed. ✨

sean1588 added the do-not-merge label Dec 7, 2022

sean1588 force-pushed the sean/registry-h1s branch 2 times, most recently from 8d8ccab to 959d9cd Compare December 7, 2022 22:10

pulumi deleted a comment from github-actions bot Dec 7, 2022

sean1588 force-pushed the sean/registry-h1s branch from 543462d to 45c00b5 Compare December 9, 2022 00:41

sean1588 marked this pull request as ready for review December 9, 2022 00:45

sean1588 force-pushed the sean/registry-h1s branch from bfa2101 to 15853fb Compare December 9, 2022 01:00

sean1588 mentioned this pull request Dec 12, 2022

registry package pages pulumi/theme#397

Merged

sean1588 requested a review from a team December 12, 2022 16:23

anita-trimbur approved these changes Dec 12, 2022

View reviewed changes

sean1588 force-pushed the sean/registry-h1s branch from 8b5e875 to bbcb4b7 Compare December 12, 2022 18:32

kimberleyamackenzie approved these changes Dec 12, 2022

View reviewed changes

sean1588 added 18 commits December 12, 2022 10:47

registry package page 1

db6f8b3

wip wip

link theme

e01cd4c

small fix

e7b99d4

indent content under card

125e3eb

address comments

8dbb1f3

link theme

548ccdb

link theme

e1ff8b2

fix text size

4c2d11e

update card

ae4abb8

link theme

36a8b3a

more fixes

c0f1e20

cleanup

ef56275

link theme

2a925fe

update theme

ff19608

cleanup

8f42b3b

update alert messsages

bdb817e

fix

ab80f0d

update theme

72d610b

sean1588 force-pushed the sean/registry-h1s branch from bbcb4b7 to 72d610b Compare December 12, 2022 18:48

sean1588 removed the do-not-merge label Dec 12, 2022

sean1588 merged commit 1122446 into master Dec 12, 2022

sean1588 deleted the sean/registry-h1s branch December 12, 2022 19:12

anita-trimbur mentioned this pull request Dec 12, 2022

notifications not visible if folks first experience is starting out on an api docs page #1356

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

registry package pages #1797

registry package pages #1797

sean1588 commented Dec 7, 2022 •

edited

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

anita-trimbur commented Dec 7, 2022 •

edited

sean1588 commented Dec 7, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

anita-trimbur commented Dec 8, 2022 •

edited

anita-trimbur commented Dec 8, 2022

susanev commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

anita-trimbur left a comment

kimberleyamackenzie left a comment

kimberleyamackenzie Dec 12, 2022

sean1588 Dec 12, 2022

github-actions bot commented Dec 12, 2022

github-actions bot commented Dec 12, 2022

github-actions bot commented Dec 12, 2022

registry package pages #1797

registry package pages #1797

Conversation

sean1588 commented Dec 7, 2022 • edited

github-actions bot commented Dec 7, 2022

github-actions bot commented Dec 7, 2022

anita-trimbur commented Dec 7, 2022 • edited

sean1588 commented Dec 7, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

anita-trimbur commented Dec 8, 2022 • edited

anita-trimbur commented Dec 8, 2022

susanev commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 8, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

anita-trimbur left a comment

Choose a reason for hiding this comment

kimberleyamackenzie left a comment

Choose a reason for hiding this comment

kimberleyamackenzie Dec 12, 2022

Choose a reason for hiding this comment

sean1588 Dec 12, 2022

Choose a reason for hiding this comment

github-actions bot commented Dec 12, 2022

github-actions bot commented Dec 12, 2022

github-actions bot commented Dec 12, 2022

sean1588 commented Dec 7, 2022 •

edited

anita-trimbur commented Dec 7, 2022 •

edited

anita-trimbur commented Dec 8, 2022 •

edited