Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud Toolkit AWS #2108

Closed
wants to merge 2 commits into from
Closed

Conversation

pasqualet
Copy link

@pasqualet pasqualet commented Feb 23, 2023

@ringods
Copy link
Member

ringods commented Mar 1, 2023

@pasqualet we have an (unfortunate & undocumented) requirement that the github repository name needs to start with pulumi- for the publishing process on our end to work correctly.

You can read more about the technicalities in this comment:

#1646 (comment)

Is it possible to rename your repository, update the link in the Pulumi schema file, rebuild and create a new release? Then you can come back here and update the listing with the new Github URL.

Sorry for all the hassle. 🙏🏻

@pasqualet
Copy link
Author

@ringods, thanks for helping with this and clarifying the limitation! I've added a slight change in the Pull Request, adding the shortName field in the package-list.json file and using it in the Continuous Integration.

In this way, we can support repositories with a custom name.
Does it work for you?

@ringods ringods requested review from sean1588 and susanev March 2, 2023 07:35
@ringods
Copy link
Member

ringods commented Mar 2, 2023

@pasqualet I asked the core maintainers of this repo to review the changes and provide feedback.

@pasqualet
Copy link
Author

@ringods @susanev @sean1588 Is there anything I can do to help review this PR?

@ringods
Copy link
Member

ringods commented Mar 20, 2023

Hello @pasqualet, sorry for the delay. Unfortunately, we can't accept this change at this moment. We have a few more dependencies on the standard naming pattern being pulumi-<packagename> in other places. If you want to be listed, the only option is for you to rename your git repository unfortunately.

@susanev
Copy link
Contributor

susanev commented Mar 24, 2023

@pasqualet is it an option to rename your repo? or is that a blocker for yall? would love to be able to get this in.

@pasqualet
Copy link
Author

@susanev I want to keep the same name for the repository and help fix this limitation in the Pulumi registry so that other projects can benefit from this improvement. Is there anything I can do from my side?

@susanev susanev self-assigned this Apr 9, 2023
@susanev
Copy link
Contributor

susanev commented Apr 26, 2023

ah okay, going to go ahead and close this for now then. we wont be able to accept this until it aligns to the repository naming convention that our systems depend on.

@susanev susanev closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants