-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloud Toolkit AWS #2108
Add Cloud Toolkit AWS #2108
Conversation
@pasqualet we have an (unfortunate & undocumented) requirement that the github repository name needs to start with You can read more about the technicalities in this comment: Is it possible to rename your repository, update the link in the Pulumi schema file, rebuild and create a new release? Then you can come back here and update the listing with the new Github URL. Sorry for all the hassle. 🙏🏻 |
d27cd2c
to
01393f8
Compare
@ringods, thanks for helping with this and clarifying the limitation! I've added a slight change in the Pull Request, adding the shortName field in the package-list.json file and using it in the Continuous Integration. In this way, we can support repositories with a custom name. |
@pasqualet I asked the core maintainers of this repo to review the changes and provide feedback. |
d948cd0
to
8e93872
Compare
8e93872
to
a20cd60
Compare
Hello @pasqualet, sorry for the delay. Unfortunately, we can't accept this change at this moment. We have a few more dependencies on the standard naming pattern being |
@pasqualet is it an option to rename your repo? or is that a blocker for yall? would love to be able to get this in. |
@susanev I want to keep the same name for the repository and help fix this limitation in the Pulumi registry so that other projects can benefit from this improvement. Is there anything I can do from my side? |
ah okay, going to go ahead and close this for now then. we wont be able to accept this until it aligns to the repository naming convention that our systems depend on. |
cloud-toolkit/cloud-toolkit-aws#83