Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve open pr matching for package updates #4025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve open pr matching for package updates #4025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/generate-package-metadata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@ jobs:
id: regex-prov
run: |
if [[ "$REPO_SLUG" =~ (\/[^-]*-)(.*?$) ]]; then
echo "group2=${BASH_REMATCH[2]}" >> $GITHUB_OUTPUT
echo "group2= ${BASH_REMATCH[2]}" >> $GITHUB_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably add a comment indicating the spaces are significant (assuming I'm reading it right).

else
echo "Regex pattern match error."
exit 1
fi
env:
REPO_SLUG: ${{ matrix.repoSlug }}
- name: Check if there is already an open PR
if: contains(needs.generate-packages-list.outputs.prs, steps.regex-prov.outputs.group2 )
if: contains(needs.generate-packages-list.outputs.prs, steps.regex-prov.outputs.group2 )
id: skip-run
run: echo "skip=1" >> $GITHUB_OUTPUT
- name: Check out registry repo
Expand Down
Loading