Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview from local machine should not appear in Activity tab #189

Closed
scav opened this issue Feb 28, 2023 · 2 comments
Closed

Preview from local machine should not appear in Activity tab #189

scav opened this issue Feb 28, 2023 · 2 comments
Labels
kind/enhancement Improvements or new features resolution/by-design This issue won't be fixed because the functionality is working as designed

Comments

@scav
Copy link

scav commented Feb 28, 2023

When a developer wants to preview their code change before submitting a PR, they can do pulumi preview on the stack in question. However, this ends up under the stack in the Pulumi Service as a logged preview.

Ideally simply running preview outside of a pipeline should be possible to without cluttering the Activity tab of the stack. To maintain insight into who did what, previews that potentially share information could be audit logged, but not added to the activity tab. E.g. a pulumi preview --local or some other mechanic to signal that we are simply checking if everything works.

Affected feature

Pulumi CLI and Pulumi Service

@scav scav added the kind/enhancement Improvements or new features label Feb 28, 2023
@EvanBoyle EvanBoyle added the resolution/by-design This issue won't be fixed because the functionality is working as designed label Mar 7, 2023
@EvanBoyle
Copy link
Contributor

@scav thanks for the suggestion. the current design is that all previews are shown until an update is run, then we collapse down those previews only showing the most recent before the update (the assumption being that the last preview matches the update).

We do want every operation to be visible and sharable within the console. We don't really distinguish between operations run within CI and locally (except for some iconography). If a local preview fails it should be easy to share a link to the output with your colleagues.

Are you running so many previews that this becomes a major problem?

@scav
Copy link
Author

scav commented Mar 7, 2023

I agree with the sentiment that every operation should be visible, I don't belive a preview necessarily qualifies as an operation (on state) in itself. Is there a limit to how many previews are shown? If someone were to run ten of them, would we eventually end up with a lower number of previews visible in the console than what actually ran?

We are not running so many previews that it has become a major problem, I just would prefer it be possible to opt out of this as it potentially adds a lot of noise to something that has no real impact on state. That is why I suggested a flag (which could probably be given a much better name) to optionally opt out of this feature if you wanted to preview a lot.

I guess since it is by design, it can be closed, and we just adapt our workflow to it.

@scav scav closed this as completed May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/by-design This issue won't be fixed because the functionality is working as designed
Projects
None yet
Development

No branches or pull requests

2 participants