-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply prewarm when benchmarking #362
Conversation
Prewarm + no parallelism makes it take a lot more time but I feel it is worth it. The numbers popping out are smaller again, and hopefully the variance will be smaller also, making them much more useful to us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I left a few comments at your discretion.
Co-authored-by: Robbie McKinstry <thesnowmancometh@gmail.com>
@lblackstone adding in case you can represent providers team here - editing shared code, wanted to make sure it's ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Wanted to make a couple of changes to improve benchmarking cron. As part of this, realized that the use cases for the test cron and benchmarking cron are diverging so I factored them out into separate code paths for easier reading.
Changes:
Also I've gotten to the bottom of PULUMI_TEMPLATE_LOCATION use I think - if unset, this tests released templates, but if set to PWD it uses locally modified copies. This is setup just fine on CI but is confusing locally when trying to test out template changes on my machine, by default the tests just ignore those changes unless I remember to set this env var. I've setup convenient make targets and documented this detail, but there's no changes to how CI runs things with respect to this env var.