Add java and yaml support #260
Conversation
Ran `go mod tidy -go=1.16 && go mod tidy -go=1.17` to specify indirect dependency tree Updated GIthub Actions scripts to use Go 1.17 to build the project
| @@ -15,7 +15,7 @@ const ubuntu = pulumi.output(aws.ec2.getAmi({ | |||
| ], | |||
| mostRecent: true, | |||
| owners: ["099720109477"], | |||
| }, { async: true })); | |||
There was a problem hiding this comment.
Hmm, I don't see this change in the original PR. I'm curious what it's been included?
There was a problem hiding this comment.
It's the current output of our codegen, so we need to make the change to get tests to pass. My assumption is that it is because async defaults to true already. See https://github.com/pulumi/pulumi/blob/18f7461d483dbb7c964d5dae4fd80147965a108c/sdk/nodejs/invoke.ts#L45-L53 for details.
| @@ -52,6 +52,12 @@ $ pulumi new python -f | |||
|
|
|||
| // For a C# project | |||
| $ pulumi new csharp -f | |||
|
|
|||
| // For a Java project | |||
There was a problem hiding this comment.
Nit: These should be in code fences with bash indicated (and should not have the prompt unless we show the output, per markdown lint).
There was a problem hiding this comment.
These are already code fenced (with console) and match the surrounding style. Which markdown lint are you running?
Duplicate of #256, hopefully running from a pulumi org member will help with tests.
Fixes pulumi/pulumi-yaml#25.