Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded port #9

Merged
merged 1 commit into from Jan 6, 2023
Merged

Remove hardcoded port #9

merged 1 commit into from Jan 6, 2023

Conversation

scottslowe
Copy link
Contributor

This PR removes a hard-coded port number to allow users to configure the frontend port via Pulumi.

Fixes #8.

Remove the hardcoded port from package.json to allow Pulumi to configure the port

Signed-off-by: Scott Lowe <slowe@pulumi.com>
@scottslowe scottslowe added this to the 0.83 milestone Jan 6, 2023
@scottslowe scottslowe requested a review from a team January 6, 2023 18:46
@scottslowe scottslowe self-assigned this Jan 6, 2023
Copy link
Member

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottslowe scottslowe merged commit 773d946 into main Jan 6, 2023
@scottslowe scottslowe deleted the slowe/fix-hardcoded-port branch January 6, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port for frontend is hardcoded
2 participants