Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated: members yaml #195

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

videmsky
Copy link
Contributor

No description provided.

@tmeckel
Copy link
Member

tmeckel commented Jun 10, 2024

@videmsky We just merged #196 which should allow running GitHub workflows from forks. Could you rebase your PR please.

@tmeckel tmeckel self-requested a review June 10, 2024 10:54
@tmeckel tmeckel self-assigned this Jun 10, 2024
@tmeckel
Copy link
Member

tmeckel commented Jun 10, 2024

@ringods the PR is using the pull_request_target configuration now, but the preview action does not show any changes. Interestingly enough it seems to use the code from the main branch and not the code from the PR.

image

https://github.com/pulumiverse/infra/actions/runs/9454396632/job/26041855502?pr=195

image

https://app.pulumi.com/pulumiverse/infra/prod/previews/532a5797-232f-4da0-972f-a59317ee54f3

@tmeckel
Copy link
Member

tmeckel commented Jun 10, 2024

@ringods It should definitely look like the following

image

@tmeckel
Copy link
Member

tmeckel commented Jun 10, 2024

@ringods Are we running into the issues discussed here actions/checkout#518?

@tmeckel tmeckel merged commit 71b34f1 into pulumiverse:main Jun 12, 2024
1 check passed
@videmsky videmsky deleted the fix-assign-admin-role branch June 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants