Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Github token to fetch schema-tools release #67

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

ringods
Copy link
Member

@ringods ringods commented Jun 5, 2023

Because schema-tools is in another repository, the Github token needs to be passed to fetch it correctly.

Change needed to get the HCP provider release working: pulumiverse/pulumi-hcp#33
Current failing build: https://github.com/pulumiverse/pulumi-hcp/actions/runs/5175283385/jobs/9322680667

@ringods ringods requested a review from simenandre June 5, 2023 09:11
@pulumi
Copy link

pulumi bot commented Jun 5, 2023

🍹 The Refresh for pulumiverse/infra/prod was successful.

Resource Changes

    Name                       Type                                                        Operation
~   terraform-migration-guide  github:index/repository:Repository                          update
~   pulumi-vra_schmidtw        github:index/repositoryCollaborator:RepositoryCollaborator  update
~   pulumi-mssql               github:index/repository:Repository                          update
~   infra                      github:index/repository:Repository                          update
~   muhlba91                   github:index/membership:Membership                          update
~   pulumi-buildkite           github:index/repository:Repository                          update
~   pulumi-hcp                 github:index/repository:Repository                          update

@pulumi
Copy link

pulumi bot commented Jun 5, 2023

🍹 The Update (preview) for pulumiverse/infra/prod was successful.

Resource Changes

    Name                    Type                                                        Operation
+-  pulumi-exoscale_dirien  github:index/repositoryCollaborator:RepositoryCollaborator  replaced
+-  pulumi-aquasec_dirien   github:index/repositoryCollaborator:RepositoryCollaborator  replaced
~   pulumi-buildkite        github:index/repository:Repository                          update
+-  pulumi-vra_schmidtw     github:index/repositoryCollaborator:RepositoryCollaborator  replaced

Copy link
Member

@simenandre simenandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure how the workflow works in its whole, but the ${{ github.token }} is scoped only to have access to this repository. Things might change when they are public however, but it's something to look out for :)

@ringods
Copy link
Member Author

ringods commented Jun 5, 2023

@simenandre I added this to a reusable workflow, meaning that "this repository" is not pulumiverse/infra, but the one calling this workflow, which in this case is pulumiverse/pulumi-hcp.

@ringods ringods merged commit dac6952 into main Jun 5, 2023
3 checks passed
@ringods ringods deleted the pass-token branch June 5, 2023 09:19
@simenandre
Copy link
Member

By the way, permissions should probably be added. Newer repositories require that by default; we should consider requiring it for all our repositories/workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants