Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the npm package name #49

Closed
wants to merge 0 commits into from
Closed

Update the npm package name #49

wants to merge 0 commits into from

Conversation

runlevel5
Copy link
Collaborator

@runlevel5 runlevel5 commented Jul 3, 2023 •
edited

The pulumi-buildkite is not correct FYI

@runlevel5 runlevel5 requested a review from muhlba91 as a code owner July 3, 2023 23:19
@muhlba91
Copy link
Collaborator

muhlba91 commented Jul 4, 2023

thank you for spotting this!
the change lgtm.

however, could you please change your commit message to follow conventional commits, and force push again? this is why the build check fails now.
in your case i‘d suggest something like „docs: fix npm package name“

@muhlba91
Copy link
Collaborator

fyi: this change will be included going forward with #50

@runlevel5 runlevel5 closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhlba91 muhlba91 muhlba91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@runlevel5 @muhlba91