Better handling of websocket headers #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evanphx can you review, please? |
geofflane
reviewed
Jan 22, 2018
httputil/reverseproxy.go
Outdated
| @@ -179,7 +179,7 @@ func (p *ReverseProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request) { | |||
| outreq.Header.Set("X-Forwarded-Proto", "http") | |||
| } | |||
|
|
|||
| if req.Header.Get("Connection") == "Upgrade" && | |||
| if strings.HasSuffix(req.Header.Get("Connection"), "Upgrade") && | |||
There was a problem hiding this comment.
Firefox says it's a comma separated list of headers. I can't tell if that's part of the standard or not? If so, it would probably be better to split on a comma. Otherwise, I think it would be better to do a Contains instead of a HasSuffix since those headers shouldn't be required to be positional.
There was a problem hiding this comment.
Makes sense. Changed to Contains
|
Awesome @evanphx! Do you have an estimate as to a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that Firefox sends a following header:
Which isn't parsed correctly by puma-dev right now, but it seems to be valid according to MDN docs.
Here's how websocket-driver parses it, but I think checking the suffix will be enough:
https://github.com/faye/websocket-driver-ruby/blob/ec94a219e91a0cf7968c076e67060c48d458b257/lib/websocket/driver.rb#L228
This closes #48