Skip to content

Commit

Permalink
Use Ruby 2.2.9 on Travis again (#1552)
Browse files Browse the repository at this point in the history
The test failures we saw after upgrading last time were caused by the
stopgap_13632 gem not being activated on the new version.
  • Loading branch information
eugeneius authored and nateberkopec committed Apr 2, 2018
1 parent 1a13e6c commit 342661f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ branches:
only:
- "master"
rvm:
- 2.2.8
- 2.2.9
- 2.3.6
- 2.4.3
- 2.5.0
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ gem "jruby-openssl", :platform => "jruby"

gem "rubocop", "~> 0.50.0"

if %w(2.2.7 2.2.8 2.3.4 2.4.1).include? RUBY_VERSION
if %w(2.2.7 2.2.8 2.2.9 2.3.4 2.4.1).include? RUBY_VERSION
gem "stopgap_13632", "~> 1.0", :platforms => ["mri", "mingw", "x64_mingw"]
end
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,10 @@ Some platforms do not support all Puma features.

## Known Bugs

For MRI versions 2.2.7, 2.2.8, 2.3.4 and 2.4.1, you may see ```stream closed in another thread (IOError)```. It may be caused by a [Ruby bug](https://bugs.ruby-lang.org/issues/13632). It can be fixed with the gem https://rubygems.org/gems/stopgap_13632:
For MRI versions 2.2.7, 2.2.8, 2.2.9, 2.3.4 and 2.4.1, you may see ```stream closed in another thread (IOError)```. It may be caused by a [Ruby bug](https://bugs.ruby-lang.org/issues/13632). It can be fixed with the gem https://rubygems.org/gems/stopgap_13632:

```ruby
if %w(2.2.7 2.2.8 2.3.4 2.4.1).include? RUBY_VERSION
if %w(2.2.7 2.2.8 2.2.9 2.3.4 2.4.1).include? RUBY_VERSION
begin
require 'stopgap_13632'
rescue LoadError
Expand Down
2 changes: 1 addition & 1 deletion test/helper.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (c) 2011 Evan Phoenix
# Copyright (c) 2005 Zed A. Shaw

if %w(2.2.7 2.2.8 2.3.4 2.4.1).include? RUBY_VERSION
if %w(2.2.7 2.2.8 2.2.9 2.3.4 2.4.1).include? RUBY_VERSION
begin
require 'stopgap_13632'
rescue LoadError
Expand Down

0 comments on commit 342661f

Please sign in to comment.