Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems shutting down gracefully after EOFErrors in 3.11.2 #1507

Closed
vincentwoo opened this issue Jan 19, 2018 · 1 comment
Closed

Problems shutting down gracefully after EOFErrors in 3.11.2 #1507

vincentwoo opened this issue Jan 19, 2018 · 1 comment

Comments

@vincentwoo
Copy link

Following @evanphx's recent fixes for read_nonblock, things seem to be working better. One last issue may remain: following the thread pool catching EOFError, shutdown of puma can take quite a while, with another EOFError being displayed before shutdown:

^C[19337] - Gracefully shutting down workers...
Error reached top of thread-pool: EOFError (EOFError)
@chytreg
Copy link

chytreg commented Feb 5, 2018

As for me and some others, it happens also during runtime as well. ref: #1502 (comment)

@tuwukee tuwukee mentioned this issue Mar 5, 2018
Closed
evanphx added a commit that referenced this issue Mar 6, 2018
@evanphx
Deal with early closes properly. Fixes #1524, #1507
b9ff900
This was referenced Mar 14, 2018
Merged
Merged
Merged
Merged
This was referenced Mar 20, 2018
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chytreg @vincentwoo @nateberkopec