Clients starved for large requests

[nixme]

2.0.0b3, MRI 1.9.3-p194, Rails 3.2.6

In development, some of our assets don't get served completely and eventually the browser times out. Content-Length comes through correctly but puma only sends a portion of the response.

Narrowed it down to syswrite at server.rb#L455 (https://github.com/puma/puma/blob/master/lib/puma/server.rb#L455). For a large asset, e.g. part.bytesize == 705661, but that client.syswrite part only returns 180224.

Even for other large assets, the syswrite always only writes 180224 bytes. For smaller files, everything is fine.

Puma never checks the return value and continues; the client waits on more data.

Any ideas?

[evanphx]

That's a bug. It needs to check the return value and call syswrite again with more of the output. #syswrite goes straight to write(2) so it's limited by the OS. This is a simply oversight.

[nixme]

I could write a patch? Should all usage of syswrite be checked and looped until fully written, or just the parts that are variable sized?

[evanphx]

I'll fix it shortly!

[nixme]

Thanks for the quick turnaround!