Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestIntegration#test_term_signal_exit_code_in_clustered_mode fails #1720

Closed
voxik opened this issue Jan 31, 2019 · 6 comments
Closed

TestIntegration#test_term_signal_exit_code_in_clustered_mode fails #1720

voxik opened this issue Jan 31, 2019 · 6 comments

Comments

@voxik
Copy link
Contributor

voxik commented Jan 31, 2019

Steps to reproduce

Running test suite, I observe the following test suite error:

TestIntegration#test_term_signal_exit_code_in_clustered_mode = [1218] Puma starting in cluster mode...
[1218] * Version 3.12.0 (ruby 2.6.0-p0), codename: Llamas in Pajamas
[1218] * Min threads: 0, max threads: 16
[1218] * Environment: development
[1218] * Process workers: 2
[1218] * Phased restart available
[1218] * Listening on tcp://127.0.0.1:9998
[1218] Use Ctrl-C to stop
[1218] - Worker 0 (pid: 1219) booted, phase: 0
[1218] - Worker 1 (pid: 1221) booted, phase: 0
[1218] - Gracefully shutting down workers...
60.00 s = E

This breaks various subsequent test cases. It reminds #1675 a bit.

System configuration

Testing on Fedora Rawhide:

$ rpm -q ruby  
ruby-2.6.0-111.fc30.x86_64

$ ruby -v
ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-linux]

$ rpm -q openssl-devel
openssl-devel-1.1.1a-1.fc30.x86_64

Puma version:
3.12.0

With two patches:

https://src.fedoraproject.org/rpms/rubygem-puma/blob/master/f/rubygem-puma-3.12.0-TLS13-fix.patch
https://src.fedoraproject.org/rpms/rubygem-puma/blob/master/f/rubygem-puma-3.6.0-fedora-crypto-policy-cipher-list.patch

@guilleiguaran
Copy link
Contributor

I think this is fixed with #1738

@voxik
Copy link
Contributor Author

voxik commented Mar 11, 2019

@guilleiguaran I applied your patch and run 30 builds on different architectures and none of the builds failed with the error in question, so you are probably right ☺️

@AlexWayfer
Copy link
Contributor

#1738 is closed in favor of #1741, which is already merged. Is this issue should be closed?

@guilleiguaran
Copy link
Contributor

Yes! I think this can be closed, @voxik can you test with master and confirm?

@voxik
Copy link
Contributor Author

voxik commented Mar 19, 2019

The patch from #1741 appears to work for me. Thx 👍

@evanphx evanphx closed this as completed Mar 20, 2019
@evanphx
Copy link
Member

evanphx commented Mar 20, 2019

This is the ruby 2.6 bug.

dentarg added a commit to dentarg/puma that referenced this issue Aug 24, 2019
dentarg added a commit to dentarg/puma that referenced this issue Aug 24, 2019
nateberkopec pushed a commit that referenced this issue Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants