Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More debug to QUERY_STRING max length #1768

Closed
ylecuyer opened this issue Apr 11, 2019 · 3 comments
Closed

More debug to QUERY_STRING max length #1768

ylecuyer opened this issue Apr 11, 2019 · 3 comments
Labels
feature

Comments

@ylecuyer
Copy link
Contributor

Steps to reproduce

  1. Make an HTTP query with a query string bigger than 1024*10

  2. read the output of puma stderr

2019-04-11 11:37:02 +0200: HTTP parse error, malformed request (127.0.0.1): #<Puma::HttpParserError: HTTP element QUERY_STRING is longer than the (1024 * 10) allowed length (was 15839)>

Expected behavior

The actual HTTP uri should be logged to know which query triggered the error

Actual behavior

The error message only shows the error and not the associated URI

System configuration

Ruby version: ruby 2.5.3p105
Rails version: Rails 4.2.11.1
Puma version: puma-3.12.0
@nateberkopec
Copy link
Member

I wonder if we should log something other than the URL too.

spk added a commit to spk/puma that referenced this issue Jul 1, 2019
@spk
Add REQUEST_PATH as fallback on parse error message
257967e 
```
2019-07-01 21:05:36 +0200: HTTP parse error, malformed request (/plop): #<Puma::HttpParserError: HTTP element QUERY_STRING is longer than the (1024 * 10) allowed length (was 20481)>
```

ref puma#1768
@spk spk mentioned this issue Jul 1, 2019
Merged
spk added a commit to spk/puma that referenced this issue Jul 1, 2019
@spk
Add REQUEST_PATH as fallback on parse error message
f15331c 
```
2019-07-01 21:31:08 +0200: HTTP parse error, malformed request (127.0.0.1/plop): #<Puma::HttpParserError: HTTP element QUERY_STRING is longer than the (1024 * 10) allowed length (was 20481)>
```

ref puma#1768
spk added a commit to spk/puma that referenced this issue Jul 1, 2019
@spk
Add REQUEST_PATH on parse error message
9d44dac 
```
2019-07-01 21:31:08 +0200: HTTP parse error, malformed request (127.0.0.1/plop): #<Puma::HttpParserError: HTTP element QUERY_STRING is longer than the (1024 * 10) allowed length (was 20481)>
```

ref puma#1768
spk added a commit to spk/puma that referenced this issue Jul 21, 2019
@spk
Add REQUEST_PATH on parse error message
55334b2 
```
2019-07-01 21:31:08 +0200: HTTP parse error, malformed request (127.0.0.1/plop): #<Puma::HttpParserError: HTTP element QUERY_STRING is longer than the (1024 * 10) allowed length (was 20481)>
```

ref puma#1768
nateberkopec pushed a commit that referenced this issue Jul 27, 2019
@spk @nateberkopec
Add REQUEST_PATH on parse error message (#1831)
0cb1088 
```
2019-07-01 21:31:08 +0200: HTTP parse error, malformed request (127.0.0.1/plop): #<Puma::HttpParserError: HTTP element QUERY_STRING is longer than the (1024 * 10) allowed length (was 20481)>
```

ref #1768
@nateberkopec
Copy link
Member

Merged on master.

@ylecuyer
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nateberkopec @ylecuyer