Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phased restart not loading new code? #185

Closed
nicolai86 opened this issue Feb 6, 2013 · 5 comments
Closed

phased restart not loading new code? #185

nicolai86 opened this issue Feb 6, 2013 · 5 comments

Comments

@nicolai86
Copy link

Hey,

I just tried out phased restarts with the latest puma beta, v2.0.0.b5 - and they seem to work. At least the workers are being restarted one by one.

Locally everything works fine, but when integrating it into a deployment using e.g. mina, code changes are not loaded.

Now I did not dig into this issue but I'd guess it has something to do with the fact that deployments normally rely on a symlink, e.g. $HOME/current for the latest release. I guess that when this symlink is updated, the workers non the less start in the old release directory.

Any clues on how to fix or nail this issue, @evanphx ?

btw: awesome puma is gaining phased restart support! thx for the great work!

@evanphx
Copy link
Member

evanphx commented Feb 6, 2013

Ah yes. I realized this just as I was going to bed last night. I need to add an option to change the directory inside the worker before loading the app. I've got one other feature to add, so I'll go ahead and fix this and release b6 today.

@evanphx evanphx closed this as completed in 40af41e Feb 6, 2013
@nicolai86
Copy link
Author

thanks!

@steverandy
Copy link

Any documentation about this feature and cluster mode?

@nicolai86
Copy link
Author

@steverandy I wrote a short blog post about how to use phased restarts just yesterday: http://blog.nicolai86.eu/posts/2013-02-06/phased-restarts-using-puma/

does that help you to get going?

@Wijnand
Copy link
Contributor

Wijnand commented Feb 7, 2013

@nicolai86 thank you for that blogpost!

@evanphx thank you for this commit, this was the last piece of the puzzle I needed to switch to puma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants