-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to start proper after 4.1.0, works fine in 4.0.1. #1905
Comments
Probably related to #1837 |
Global Lines 114 to 138 in a3e18cb
|
https://github.com/puma/puma/blob/v4.1.0/lib/puma/launcher.rb#L399 I'm not terribly familiar with this section, but this stack trace indicates SIGTERM is being raised which is killing the processes? |
@nafaabout Yes, confirm with #1837 , after rollback 2 line changes, now puma can start properly. |
@Eric-Guo your puma.rb works for me with minor path changes on 4.1.0 on OS X using config.ru:
What OS are you using? |
It's a production server running CentOS 7 and deploys using |
have exactly the same issue — rolled back to 4.0.1 def graceful_stop
@runner.stop_blocked
log "=== puma shutdown: #{Time.now} ==="
log "- Goodbye!"
end |
1 potential fix is to revert #1837 , and expect people who want puma.rb: on_worker_boot do
STDERR.sync = STDOUT.sync = false
end The other potential fix would be to not We can add explicit |
Closing to merge with #1906 |
Steps to reproduce
Just upgrade to 4.1.0.
puma.rb file:
Expected behavior
Should start properly.
Actual behavior
Not start properly.
System configuration
Ruby version: 2.6.3
Rails version: 5.2.3/6.0.0.rc2
Puma version: 4.1.0
The text was updated successfully, but these errors were encountered: