New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Rails 7.1
with Ruby head in turbo-rails
CI
#3320
Conversation
5deeea1
to
290da09
Compare
7.1
in turbo-rails
CI
44a8f89
to
5b9a1c9
Compare
7.1
in turbo-rails
CI7.1
with Ruby head in turbo-rails
CI
https://github.com/puma/puma/actions/runs/7529388305/job/20493515442 was using concurrent-ruby 1.2.2: |
Ah yep my bad, the confusion was from me looking at the diff for the incorrect version. I thought it was from requiring Thanks for having a look! |
@eregon Thanks for the research. Note the last rows of https://github.com/ruby/ruby/blame/master/gems/bundled_gems. There have been more additions after @joshuay03 - thanks for the PR. I haven't thought about it much (busy), but these jobs don't take long, wondering if there should be a mix of 7.0 and 7.1? |
Sounds good to me, I'll action when I get a chance 👍🏽 Edit: Actioned here. |
f254b9d
to
b410140
Compare
b410140
to
945cf4a
Compare
|
Thank you @dentarg |
Description
Context:
Experiment to see if this fixes a failing CI worflow since
mutex_m
was added to the relevant Rails gemfiles and included in the7.1
release. It has also since been dropeed on Rails edge.Even if this passes, the root cause is that it's missing from the gemfiles in https://github.com/ruby-concurrency/concurrent-ruby. I'm hoping to resolve that in ruby-concurrency/concurrent-ruby#1034.However, we still need to point to a version of Rails that either requiresmutex_m
itelf or uses a version ofconcurrent-ruby
that does, so this change is needed regardless of that patch.I've also pointed the other rubies to
7.1
for consistency, please let me know if I should revert that.Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.