Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated load path #1095

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Conversation

junaruga
Copy link
Contributor

When we would run test, the load path "lib:bin:test:." is loaded by Hoe test default settings.

https://github.com/seattlerb/hoe/blob/master/lib/hoe.rb#L106

So, I think we do not need to set load path in test/testhelp.rb again.
How do you think?

$ bundle exec rake test
...
/usr/local/ruby-2.3.1/bin/ruby -w -Ilib:bin:test:. -e 'require "rubygems"; require "minitest/autorun"; require "test/test_thread_pool.rb"; require "test/test_puma_server.rb"; require "test/test_app_status.rb"; require "test/test_rack_server.rb"; require "test/test_minissl.rb"; require "test/test_tcp_logger.rb"; require "test/test_unix_socket.rb"; require "test/test_tcp_rack.rb"; require "test/test_null_io.rb"; require "test/test_http10.rb"; require "test/test_rack_handler.rb"; require "test/test_persistent.rb"; require "test/test_ws.rb"; require "test/test_puma_server_ssl.rb"; require "test/test_config.rb"; require "test/test_iobuffer.rb"; require "test/test_integration.rb"; require "test/test_cli.rb"; require "test/test_http11.rb"' --
...

Below tests were also passed.

$ bundle exec rake test
$ bundle exec rake test:integration

@evanphx evanphx merged commit 43bf354 into puma:master Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants