Improve required testhelp.rb path. #1096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time I sent pull-request to change testhelp.rb path, and it was merged. (73bf56c).
I think it might be my mistake.
Because it looks usual to set "lib" and "test" as a ruby path than "lib" and ".".
Though it may be small thing.
For example, below Rake TestTask is using both "lib" and "test" below page.
http://rake.rubyforge.org/classes/Rake/TestTask.html
t.libs << "test"
Maybe hoe that is used in our Rakefile, its test way is kind of special, because of "lib:bin:test:.". "." is set as a Ruby load path.
I think that Including "." causes a duplicated path situation.
I am asking hoe community for this point now. (seattlerb/hoe#74)
So, this pull-request's modification looks better than before right now.
Below tests are passed.
How do you think?
Thank you.