Replace use of Process.getpgid which does not behave as intended on all platforms #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it was a hung build? |
|
@montdidier Can you remove the Puma version bump and Puma::StateFile commits (so leaving only b7a6879). We're gonna fix the others separately. (cc #1138) |
|
@montdidier LGTM but I don't think we have test coverage for the failure case? Can you add one? |
|
Sorry for slow response. Will update as requested. |
montdidier
force-pushed
the
replace_getpgid
branch
from
d611b71
to
20b780e
Compare
|
Ok. I've removed the Puma version bump and Puma::StateFile and added a test to cover the failure case. Anything else? |
|
Brilliant! We'll take it from here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has two small fixes for issues I experienced with puma 3.6.0
Process.getpgid is being used to confirm the existence of a running process before proceeding on to act upon said process.
Using this man page as a reference one can see that unless getpgid is called from within the same session as the running process a permission error will be returned. Considering the main uses cases; running in the same session will not be the norm. The exception handling block surrounding Porcess.getpgid does not differentiate between an unknown process id and permission denied. Therefore the error "unknown pid" is returned and execution ceases.
Considering that the various kill methods in waiting result in the same exception I decided to simply change the method logic from "asking permission" to "asking forgiveness" and circumventing the need for Process.getpgid all-together.