Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the issue of @listeners getting nil io #1120

Merged
merged 3 commits into from
Nov 21, 2016
Merged

Fixed the issue of @listeners getting nil io #1120

merged 3 commits into from
Nov 21, 2016

Commits on Nov 21, 2016

  1. Fixed the issue of @listeners getting nil io 

    - `add_tcp_listener` and `add_ssl_listener` return `nil` now for
  localhost addresses and it was getting added to the `@listeners`.
- Later on the file descriptor `nil` was getting converted to 0 and
  resulting into `BadFileDescriptor` error as per this gist -
  https://gist.github.com/prathamesh-sonpatki/bc0cac8929dbf17316e8b4b7dda93e20.
- This issue is now fixed and added test case.
- This fixes `rails restart` command on Rails 5 + Puma 3.5 and above.
    @prathamesh-sonpatki
    prathamesh-sonpatki committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    1f5d926 View commit details
    Browse the repository at this point in the history

  2. Test localhost ssl:// as well

    @skull-squadron @prathamesh-sonpatki
    skull-squadron authored and prathamesh-sonpatki committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    92d590f View commit details
    Browse the repository at this point in the history

  3. Skip tests related to localhost binding on JRuby 

    - Added a helper for omitting tests on JRuby.
    @prathamesh-sonpatki
    prathamesh-sonpatki committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    08a00f7 View commit details
    Browse the repository at this point in the history