Remove Bundler dependency from tests.

[junaruga]

Hello,

Is it possible not to use "bundler/setup" in tests?

Because I am managing puma's RPM package in Fedora project.
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-puma/

And we are running the puma unit tests without Bundler like this.
Though not using bundler is kind of our Fedora project's custom.

ruby \
  -r 'minitest/autorun' \
  -e 'Dir.glob "./test/**/test_*.rb", &method(:require)' \
  -- -v

I know Bundler is useful for travis or local environment.
However I am happy that the tests do not depends on Bundler.

Thanks!

[nateberkopec]

I'll let @schneems and @evanphx weigh in, but my gut reaction is this is a "no". Bundler is sort of the de facto in Ruby now, so I don't see any gain in removing it.

[evanphx]

@junaruga Rather than remove it like this, I'd be happy to accept a patch that conditionalized requiring. Perhaps if ENV["NO_BUNDLER"] as the check.

[junaruga]

@nateberkopec yeah I can understand your thoughts.
@evanphx ok I will send the patch! Thanks for the idea!

[junaruga]

@evanphx I update using begin - rescure instead of using environment variable.
It is easier for me not to use environment variable.
How?

[junaruga]

As other possible solutions, I want to suggest if ENV["BUNDLER_VERSION"] and if defined?(Bundler).

$ bundle exec ruby -e 'puts ENV["BUNDLER_VERSION"] ? "True" : "False"'
True
$ ruby -e 'puts ENV["BUNDLER_VERSION"] ? "True" : "False"'
False

$ bundle exec ruby -e 'puts defined?(Bundler) ? "True" : "False"'
True

$ ruby -e 'puts defined?(Bundler) ? "True" : "False"'
False

[junaruga]

On the Travis tests, only Ruby 2.3.3 failed with below Timeout::Error. However it is false positive isn't it?

TestThreadPool#test_trim_is_ignored_if_no_waiting_threads = /home/travis/build/puma/puma/lib/puma/thread_pool.rb:268:in `join': execution expired (Timeout::Error)

[evanphx]

Thanks!