Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test error #1236

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Fix test error #1236

merged 1 commit into from
Mar 9, 2017

Commits on Mar 8, 2017

  1. Fix test error

    We got following error on travis now:
    
    https://travis-ci.org/puma/puma/jobs/207434226
    
    ```
    1) Error:
    WebServerTest#test_simple_server:
    NameError: uninitialized constant Net
        /home/travis/build/puma/puma/test/test_helper.rb:24:in `block in hit'
        /home/travis/build/puma/puma/test/test_helper.rb:20:in `each'
        /home/travis/build/puma/puma/test/test_helper.rb:20:in `hit'
        /home/travis/build/puma/puma/test/test_web_server.rb:36:in `test_simple_server'
    ```
    
    I confirmed test passed with bundler 1.14.4 but errored with 1.14.5.
    
    rubygems/bundler@v1.14.4...v1.14.5
    
    The cause is rubygems/bundler@984f64d
    because `rubygems/spec_fetcher` requires `net/http` internally but is deferred now.
    
    I think we should require stdlibs explicitly.
    mtsmfm committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    0b3424a View commit details
    Browse the repository at this point in the history