Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Socket.ip_address_list to get loopback addresses #1318

merged 1 commit into from Aug 3, 2017


Copy link

@nateberkopec nateberkopec commented Jun 3, 2017

This will fix #1167

See JRuby bug

Need some guidance from @evanphx here: is binder supposed to bind to only loopback interfaces by default (as I've done in this PR) or is it supposed to bind to linklocal addresses as well?

Here's what this method returned before (my machine, CRuby):

["::1", "fe80::1%lo0", ""]


["", "::1"]

Note the omission of an ipv6 link-local interface. The reason I removed it was that there are several other link-local interfaces on my machine which I don't think puma should bind to:

irb(main):013:0> do |addrinfo|
irb(main):014:1* addrinfo.ipv6_linklocal?
irb(main):015:1> end
=> [#<Addrinfo: fe80::1%lo0>, #<Addrinfo: fe80::4b:c017:51b5:cd33%en0>, #<Addrinfo: fe80::989b:30ff:fe14:9e01%awdl0>, #<Addrinfo: fe80::f16e:6368:16b5:ff60%utun0>]

@evanphx if you can clarify the intent here, I'll add a test.

Copy link
Member Author

Ah, I think I get it now. Linking #782.

@nateberkopec nateberkopec removed the request for review from evanphx June 3, 2017 23:00
Copy link
Member Author

I'm also going to link #1022 here, because the original fix here caused that issue, maybe I can satisfy everyone.

@nateberkopec nateberkopec self-assigned this Jun 4, 2017
@evanphx evanphx self-requested a review June 4, 2017 20:49
Copy link

@evanphx evanphx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When did Socket.ip_address_list show up? Do we need to be worried about ruby compat?

Copy link
Member Author

Looks like it's in 1.9.3, so no.

Copy link
Member Author

Also, JRuby returns the same result as CRuby does here, though it prints the full ipv6 address rather than the short ::1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

gethostbyname "localhost" is not a reliable solution for localhost addresses
2 participants